Expose Settings in the sidebar Help menu - #13211
Conversation
|
Warning Review limit reachedNext included review available in 20 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
The exact failing compiler logs reported missing AgentPIDProcessIdentity imports inherited from the baseline. Applied upstream #13236 in |
|
Full-suite evidence at2b70fcfa11c832d9277dc009d4948f88500800dc: app+test compile admission and package gates passed; runtime shards1/4/6 currently fail. Example run35526810022 jobs106124368848,106124368804,106124368910. These are real test failures across shared CLI, Cloud, persistence, browser and focus suites, not compilation-only evidence. One source-verified baseline defect: CLIVMLayoutEnvTests supplies --workspace and --name together although the production parser explicitly rejects that combination. Shared baseline repair is coordinated centrally rather than changing unrelated assertions here. The PR is not ready to merge while required runtime gates remain red. |
2b70fcf to
5c2098a
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Reviewer summary
Adds Settings to the sidebar Help menu so it is reachable from the same place as the other support and discovery links.
Checks
The sidebar Help popover now exposes the existing native Settings window directly. Settings sits with Keyboard Shortcuts and Import Browser Data near the top of the menu, ahead of feedback and external resources, and shows the user’s configured Settings shortcut.
Selecting Settings dismisses the popover and routes through the same presenter used by the app menu and Command-comma. No new Settings surface or onboarding flow is introduced.
Testing
main; fresh current-head CI is still required.Scope
This PR is intentionally limited to the Help-menu entry, ordering, shortcut hint, and behavior coverage.
Summary by CodeRabbit
New Features
Improvements
Replaces #12981 (same commits, head branch moved into the org so it gets the build cache and can be kept current with main).
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds a Settings entry to the sidebar Help menu so users can open the existing Settings window from the same popover as the other support links.
import CmuxFoundationto several source files to unblock native compile admission.Written for commit 5c2098a. Summary will update on new commits.