Repository navigation
ci: retry Warp checkout and capture DNS failures #13199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
teamleaderleo
wants to merge
1
commit into
manaflow-ai:main
from
teamleaderleo:ci-warp-network-reliability
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #!/usr/bin/env bash | ||
| set -u | ||
|
|
||
| # Keep provider/network evidence in the job log without failing the original | ||
| # operation. These commands are intentionally read-only and emit no tokens. | ||
| echo "== network diagnostics (runner=${RUNNER_NAME:-unknown}) ==" >&2 | ||
| if command -v scutil >/dev/null 2>&1; then | ||
| scutil --dns 2>&1 || true | ||
| fi | ||
| if command -v route >/dev/null 2>&1; then | ||
| route -n get default 2>&1 || true | ||
| fi | ||
| if command -v ifconfig >/dev/null 2>&1; then | ||
| ifconfig 2>&1 || true | ||
| fi | ||
| if command -v dscacheutil >/dev/null 2>&1; then | ||
| dscacheutil -q host -a name github.com 2>&1 || true | ||
| fi | ||
| if command -v curl >/dev/null 2>&1; then | ||
| curl --connect-timeout 5 --max-time 10 --silent --show-error --head https://github.com/ 2>&1 || true | ||
| fi | ||
| echo "== end network diagnostics ==" >&2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a fresh runner, a failure while fetching the main repository can leave
GITHUB_WORKSPACEwithoutscripts/ci/capture-network-diagnostics.sh. The double-checkout failure step then reports that the script is missing instead of capturing the DNS evidence it was added to collect. The same issue applies to the diagnostic call inmacos-compile-admissionat line 2496. Make these diagnostics available independently of a successful repository checkout, such as by inlining them in the workflow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in upstream replacement #13204, commit 6842bd9. Both checkout-failure steps now inline the diagnostic commands and have a one-minute step limit. Regression eb3190a executes both real workflow bodies from empty workspaces: it fails before the fix and passes afterward, including probe errors while retaining the final exit 1. This PR is being superseded because its source repository cannot be changed from teamleaderleo/cmux to manaflow-ai/cmux; the replacement links this review history.