Skip to content

ci: skip the Ghostty release helper when Release is skipped - #13175

Merged
teamleaderleo merged 1 commit into
ci-route-release-buildfrom
ci-route-release-helper
Sep 20, 2026
Merged

teamleaderleo merged 1 commit into
ci-route-release-buildfrom
ci-route-release-helper

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

#13122 skips the Release app build for test-source-only changes, but swift-package-tests still installs the SDK-15 helper toolchain and Zig, restores its cache, builds the universal Ghostty CLI, and uploads an artifact that no job consumes.

Gate those helper steps on the same release_build output as their sole consumer. The upload retry also requires that output. Package testing, app-host compilation, and all app-host shards keep their existing routing. Runs that require Release still produce the helper with the same SDK and architecture checks.

Stacked on #13122, which introduces release_build. #13118 separately selects affected package tests; neither existing PR gates this helper work. The older #2416 avoids incidental Zig builds in app build scripts and does not cover this explicit artifact producer.

This removes the helper work when Release is skipped, not the entire package job. The parent conservatively enables Release for any project.pbxproj edit, so a new-test PR such as #13173 still runs Release and the helper. Distinguishing test-only project wiring remains separate.

Validation

  • CI change-area tests pass, including test-only skips and app/project/toolchain inputs that retain Release.
  • Web validation, release-build timeout, self-hosted runner/artifact guards, and reusable-workflow permission tests pass.
  • Actionlint and git diff --check pass.
  • No app or package runtime code changed; hosted validation and timing remain pending.

Related: #13095.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Skips the Ghostty release helper work in swift-package-tests when the Release build is skipped. Previously the job still provisioned the SDK-15 toolchain, installed Zig, built the universal CLI, and uploaded an artifact no job consumed; those steps now run only when release_build is true, and the upload retry follows the same condition.

Written for commit a14fa0d. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo merged commit a14fa0d into ci-route-release-build Sep 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant