ci: skip the Ghostty release helper when Release is skipped - #13175
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#13122 skips the Release app build for test-source-only changes, but
swift-package-testsstill installs the SDK-15 helper toolchain and Zig, restores its cache, builds the universal Ghostty CLI, and uploads an artifact that no job consumes.Gate those helper steps on the same
release_buildoutput as their sole consumer. The upload retry also requires that output. Package testing, app-host compilation, and all app-host shards keep their existing routing. Runs that require Release still produce the helper with the same SDK and architecture checks.Stacked on #13122, which introduces
release_build. #13118 separately selects affected package tests; neither existing PR gates this helper work. The older #2416 avoids incidental Zig builds in app build scripts and does not cover this explicit artifact producer.This removes the helper work when Release is skipped, not the entire package job. The parent conservatively enables Release for any
project.pbxprojedit, so a new-test PR such as #13173 still runs Release and the helper. Distinguishing test-only project wiring remains separate.Validation
git diff --checkpass.Related: #13095.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Skips the Ghostty release helper work in
swift-package-testswhen the Release build is skipped. Previously the job still provisioned the SDK-15 toolchain, installed Zig, built the universal CLI, and uploaded an artifact no job consumed; those steps now run only whenrelease_buildis true, and the upload retry follows the same condition.Written for commit a14fa0d. Summary will update on new commits.