Repository navigation
docs: list team in the cmux auth help contract (unblocks app-host shard 6) - #13153
Conversation
The help contract probe in tests/test_cli_contract_help.py reads its expected strings from docs/cli-contract.md. The auth usage line gained `team` in the CLI but not in the contract, so the strict "Run CLI no-socket regressions" step fails on app-host shard 6 for every macOS-routed pull request merged with current main. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe CLI contract now documents the ChangesAuth team CLI contract
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: 🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ke server tests/test_claude_hook_clear_running_status.py runs a fake cmux socket server that answers every command. Hook commands are fire-and-forget: the CLI often closes the socket before the reply is written, so the server thread died with BrokenPipeError and printed a traceback (8 per run) into the CI log above the test's own PASS line. The test result never depended on the reply. Treat a closed client as the end of that connection. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
02cd032 docs: list team in the cmux auth help contract (unblocks app-host shard 6) (manaflow-ai#13153) fc245a8 Cancel queued Cloud creates when their provider retires (manaflow-ai#13150)
Summary
docs/cli-contract.mdstill listedUsage: cmux auth <status|login|logout>. The CLI has printed<status|login|logout|team>since Team picker: switch/create teams and scope Cloud #13051.tests/test_cli_contract_help.pyreads its expected help text from that file, so the strict "Run CLI no-socket regressions" step fails on app-host shard 6 for every macOS-routed PR merged with currentmain. Seen on Add app-host test failure census #13124, test: split an expression Xcode 27 cannot type-check #13126, and on theissue-12758-plain-paste-latencyand13019-team-picker-switch-createbranches.auth team list|use|createsubcommands in the auth table.tests/test_claude_hook_clear_running_status.py's fake socket server replied to fire-and-forget hook commands after the CLI had closed the socket, so its thread died withBrokenPipeError(8 tracebacks per run) right above the test's ownPASSline. A closed client now just ends that connection. The test's result never depended on the reply.Testing
Usage: cmux auth <status|login|logout|team>(https://github.com/manaflow-ai/cmux/actions/runs/35489908957/job/106025351249). The probe line now equals it.docs/, so the router skips the Mac jobs here. The first macOS-routed PR that mergesmainafter this lands exercises the step.CMUX_CLI_BIN=… python3 tests/test_claude_hook_clear_running_status.py), 5 runs each: before, 8BrokenPipeErrortracebacks per run and PASS; after, 0 tracebacks and PASS.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Corrects the
cmux authhelp contract indocs/cli-contract.mdso the documented usage includesteam, matching the CLI's actual output and unblocking the strict no-socket regression check on app-host shard 6. Also makes the Claude hook test's fake server tolerate fire-and-forget clients.auth team list|use|createsubcommands in the auth table.BrokenPipeErrorand dumped tracebacks into CI logs; it now treats a closed client as a clean end of connection.Written for commit ffa5e7a. Summary will update on new commits.
Summary by CodeRabbit
Documentation
Bug Fixes