perf: split BrowserPanelView's modifier chain so it type-checks quickly

[teamleaderleo]

Moved from #13105 with the same commits.

Summary

• BrowserPanelView's body ended in one chain of 20 modifiers (coordinateSpace, three onPreferenceChange, two onReceive, onAppear/onDisappear, twelve onChange). The compiler type-checks that chain as a single expression, and it was the slowest expression in the app module.
• This splits the chain into three computed views (browserPanelLifecyclePreferencesView -> browserPanelLifecycleNotificationsView -> the onChange group). The modifiers, their closures and their order are unchanged; nothing else in the file is touched.

Testing

Measured on one machine (MacBook Air M5, Xcode 27.0) with -Xfrontend -warn-long-expression-type-checking=200 -Xfrontend -warn-long-function-bodies=200:

Sources/Panels/BrowserPanelView.swift	before	after
sites over 200 ms	4	0
slowest expression (:1073)	8,120 ms in a cold build under load; 6.8 s in an unloaded profile	under 200 ms

• The threshold crossing is the result to rely on, not the millisecond values: the "before" number comes from a cold parallel build.
• Whole-build wall clock: no measurable change on a 10-core machine (the file compiles in parallel with ~3,700 others). What it removes is a multi-second floor on every incremental build that recompiles this file.
• xcodebuild -scheme cmux -configuration Debug build on this branch: BUILD SUCCEEDED.
• Not tested: UI behaviour by hand (launching a tagged build needs dev credentials that are not on the benchmark machine). The change is a mechanical regrouping of modifiers in the same order.
• Next slowest site in the module, not addressed here: Sources/Surfaces/SurfaceCatalog+CloudPorts.swift:37 (2.7 s).

Demo Video

Not applicable: no behaviour change.

Checklist

• I tested the change locally
• I added or updated tests for behavior changes (none: no behaviour change)
• I updated docs/changelog if needed (not needed)

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Speeds up type-checking of BrowserPanelView by splitting its 20-modifier chain into three computed views. Modifiers, closures, and order are unchanged, so there is no behavior change.

Testing

• Slowest expression in Sources/Panels/BrowserPanelView.swift drops from ~8 s to under 200 ms.
• Whole-build wall clock is unchanged; the win is on incremental rebuilds of this file.
• xcodebuild -scheme cmux -configuration Debug build succeeds.

^{Written for commit 31ddfd6. Summary will update on new commits.}

Summary by CodeRabbit

• Refactor
  • Reorganized the browser panel’s internal view lifecycle structure without changing visible behavior or functionality.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c15a56f1-3184-4660-b76d-e611c45da241

📥 Commits

Reviewing files that changed from the base of the PR and between 02cd032 and 31ddfd6.

📒 Files selected for processing (1)

• Sources/Panels/BrowserPanelView.swift

Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.

---

📝 Walkthrough

Walkthrough

The browser panel lifecycle view is decomposed into three nested private computed properties. The existing preference, notification, lifecycle, and change modifiers remain in the same order with the same handlers.

Changes

Browser panel lifecycle decomposition

Layer / File(s)	Summary
Nested lifecycle view wrappers Sources/Panels/BrowserPanelView.swift	browserPanelLifecycleView now delegates through notification and preference view properties. Existing modifiers and handler behavior remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Suggested reviewers: austinywang

🚥 Pre-merge checks | ✅ 25

✅ Passed checks (25 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: splitting BrowserPanelView’s modifier chain to improve type-checking performance.
Description check	✅ Passed	The description includes a detailed summary, rationale, testing results, build verification, and an appropriate explanation that no demo video is needed. It omits the template’s review-trigger block a…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input	✅ Passed	PASS: The pull request changes only Sources/Panels/BrowserPanelView.swift. The diff moves the existing preference, notification, lifecycle, and onChange modifiers into three computed views. It doe…
Cmux Swift Actor Isolation	✅ Passed	PASS. The review range changes only Sources/Panels/BrowserPanelView.swift. The diff moves the existing coordinate-space, preference, notification, appearance, and onChange modifiers into three private…
Cmux Swift Blocking Runtime	✅ Passed	PASS. The PR changes only Sources/Panels/BrowserPanelView.swift and only splits an existing SwiftUI modifier chain into computed views. The diff adds no semaphores, waits, sleeps, polling, synchrono…
Cmux Browser Automation Off-Main	✅ Passed	PASS. The PR changes only Sources/Panels/BrowserPanelView.swift. The diff only splits existing SwiftUI lifecycle modifiers into computed views and preserves their order and handlers. It does not cha…
Cmux Expensive Synchronous Load	✅ Passed	PASS. The authoritative diff changes only Sources/Panels/BrowserPanelView.swift and splits an existing SwiftUI modifier chain into computed views. The added lines contain no `RestorableAgentSessionI…
Cmux Cache Substitution Correctness	✅ Passed	PASS. The pull request changes only Sources/Panels/BrowserPanelView.swift and only restructures the SwiftUI modifier chain into computed views. It does not replace a fresh authoritative read with a …
Cmux No Hacky Sleeps	✅ Passed	PASS: The review-scoped diff changes only Sources/Panels/BrowserPanelView.swift, which is Swift and outside this check's non-Swift scope. The added lines only split SwiftUI computed views and add no…
Cmux Algorithmic Complexity	✅ Passed	PASS. The pull request changes only Sources/Panels/BrowserPanelView.swift. It splits an existing 20-modifier SwiftUI chain into computed views. The verified modifier count and semantic order are unc…
Cmux Swift Concurrency	✅ Passed	The pull request changes only Sources/Panels/BrowserPanelView.swift. The diff splits one existing SwiftUI modifier chain into three computed views and preserves the existing .onReceive, `.onAppear…
Cmux Swift @Concurrent	✅ Passed	PASS. The PR changes only Sources/Panels/BrowserPanelView.swift and only splits an existing synchronous SwiftUI modifier chain into three computed some View properties. The diff adds no async, `…
Cmux Swift Package Boundaries	✅ Passed	PASS. The only changed file is Sources/Panels/BrowserPanelView.swift. The diff only splits an existing SwiftUI modifier chain into private computed views within BrowserPanelView; it does not add i…
Cmux Swiftpm Lockfiles	✅ Passed	PASS. The authoritative PR diff changes only Sources/Panels/BrowserPanelView.swift. It contains no Package.swift, Package.resolved, .gitignore, workflow, Xcode project, or dependency changes. …
Cmux Swift Logging	✅ Passed	PASS: The review-scoped diff changes only Sources/Panels/BrowserPanelView.swift and only splits the existing SwiftUI modifier chain into computed views. It adds or changes no print, debugPrint, …
Cmux User-Facing Error Privacy	✅ Passed	PASS. The review-scoped diff changes only Sources/Panels/BrowserPanelView.swift. It moves existing SwiftUI modifiers into three computed views. It adds no user-facing error, alert, command output, A…
Cmux Full Internationalization	✅ Passed	PASS: The authoritative diff changes only Sources/Panels/BrowserPanelView.swift. It relocates the existing modifier chain into three computed views. The patch adds no user-facing Swift text, localiz…
Cmux Swiftui State Layout	✅ Passed	PASS. The authoritative diff only reorganizes the existing modifier chain in BrowserPanelView into computed views. It adds no state declarations, store references, list rows, or geometry readers. Ba…
Cmux Architecture Rethink	✅ Passed	PASS. The PR changes only Sources/Panels/BrowserPanelView.swift. It splits one existing modifier chain into private computed some View properties within the same BrowserPanelView. Base and head …
Cmux Swift Auxiliary Window Close Shortcuts	✅ Passed	PASS: The PR changes only Sources/Panels/BrowserPanelView.swift and splits an existing SwiftUI modifier chain into computed views. The diff adds no NSWindow, NSPanel, NSWindowController, `Wind…
Cmux Source Artifacts	✅ Passed	The pull request changes only Sources/Panels/BrowserPanelView.swift. The patch contains hand-written Swift source that splits view modifiers into computed properties. It adds no logs, screenshots, r…
Cmux No Test Or Debug Seam In Production Source	✅ Passed	PASS — The authoritative PR diff changes only Sources/Panels/BrowserPanelView.swift. It only splits the existing SwiftUI modifier chain into three private computed views and adds no #if DEBUG or…

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge because the refactor preserves the existing SwiftUI modifier hierarchy and introduces no actionable issues.

Summary

Splits BrowserPanelView’s long SwiftUI modifier expression into three computed views to reduce type-checking time.

• Preserves the original modifier ordering and closures.
• Separates preference handling, notifications/lifecycle handling, and change observers.
• Introduces no behavioral or security changes.

_{Reviews (2) · Last reviewed commit: "Merge branch 'main' into perf/browser-pa..."}

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.