Skip to content

ci: refresh cmuxTests shard timings - #13068

Merged
austinywang merged 2 commits into
manaflow-ai:mainfrom
teamleaderleo:ci-refresh-unit-test-timings
Sep 20, 2026
Merged

austinywang merged 2 commits into
manaflow-ai:mainfrom
teamleaderleo:ci-refresh-unit-test-timings

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Regenerates scripts/ci/cmux-unit-test-timings.json with scripts/ci/generate_test_timings.py from the six app-host shard logs of https://github.com/manaflow-ai/cmux/actions/runs/35427062807. Data only, no planner change.

The old manifest covered 522 suites, the target now has 1142. Measured selectors go from 2070 to 2458 of 2790, so 388 fewer selectors are packed at the 200 ms default.

Expected effect

Small. Replaying the old plan against the new measurements puts the heaviest shard at 1.19x the mean, the new plan at 1.0x. That is about 3 minutes off the slowest shard's test step.

The large shard 6 outlier (47 min median) is mostly not planner weight. In the source run shard 6 spent 1250 s in Run unit tests with under 200 s of measured test time: four app-host crash restarts (#9348) and three RemoteTmuxMirrorPaneInputMappingTests cases that each sat about 5 minutes. Shard 6 also carries about 400 s of pinned regression steps the planner does not see. Those are separate follow-ups.

Testing

  • python tests/test_ci_cmux_unit_test_shard.py passes
  • python3 scripts/ci/cmux_unit_test_shard.py --validate: 2458/2790 measured

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Refreshes the CI shard timings manifest with measurements from the latest green shard logs so sharding follows the current test suite and the slowest shard runs less.

The regenerated manifest now has measured timings for 2458 of 2790 selectors, up from 2070, so fewer tests fall back to the 200 ms default. Replaying the new plan puts the heaviest shard at 1.0x the mean instead of 1.19x, saving about 3 minutes on the slowest shard's test step. This is data only; the planner logic is unchanged. Both tests/test_ci_cmux_unit_test_shard.py and scripts/ci/cmux_unit_test_shard.py --validate pass. The known shard 6 outlier is separate, caused by crash restarts and pinned regression steps rather than planner weight.

Written for commit 443f1c6. Summary will update on new commits.

Review in cubic

The manifest covered 522 suites. The test target now has 1142, so over
a quarter of selectors were packed at the 200 ms default. Regenerated
with scripts/ci/generate_test_timings.py from six green shard logs:
931 suites and 1447 methods, 2458 of 2790 selectors measured.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: fda46ee7-7c8a-4f0e-bbd8-62364a523124

📥 Commits

Reviewing files that changed from the base of the PR and between 1d3ee58 and 443f1c6.

📒 Files selected for processing (1)
  • scripts/ci/cmux-unit-test-timings.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@greptile-apps

greptile-apps Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because it only refreshes validated shard timing data and introduces no actionable issue.

Summary

Refreshes the generated cmux unit-test timing manifest using a newer CI run so shard planning reflects the current test suite.

  • Expands timing coverage to 1,142 suites.
  • Records measurements for 2,458 of 2,790 discovered selectors.
  • Leaves shard-planner behavior unchanged.
  • The timing-manifest tests and validation command pass.

Reviews (2) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..."

@teamleaderleo
teamleaderleo enabled auto-merge (squash) September 19, 2026 22:40
@cursor

cursor Bot commented Sep 19, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@austinywang
austinywang merged commit bd980f6 into manaflow-ai:main Sep 20, 2026
29 of 30 checks passed
rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 20, 2026
286b523 docs(agents): run the compile-only check in the tag's derived data (manaflow-ai#13033)
bd980f6 ci: refresh cmuxTests shard timings from run 35427062807 (manaflow-ai#13068)
@teamleaderleo
teamleaderleo deleted the ci-refresh-unit-test-timings branch September 23, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants