Repository navigation
feat: add native discovery for configured actions - #13045
teamleaderleo wants to merge 7 commits into
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
teamleaderleo
left a comment
There was a problem hiding this comment.
I found two bounded edge cases in the new discovery/management surface. Both come from the fact that the panel intentionally includes the resolved project-local registry, while some of the UI still loses source/action identity.
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
teamleaderleo
left a comment
There was a problem hiding this comment.
Follow-up on the two earlier findings: current head fc6a118f7313b3f7c3478f53b524b3226598e76b addresses both cleanly.
surfaceTabBarActionReferenceIDscarries the canonical action reference through resolution and is filtered against the final visible button IDs, so equal resolved payloads no longer conflate action placement; the duplicate-payload test pins it.- the config action now says exactly which global path it will open, while project-local rows continue to display their own source paths.
I did a focused read of the new identity map and found no additional issue in that follow-up.
|
Replaced by #13232: same commits, head branch moved into the org. |
Reviewer summary
Shows configured actions in the existing discovery surfaces, with stable identity and the right global-versus-project scope. The change reuses the current action and settings owners.
What changed
Adds the smallest native discovery/management surface for the existing
cmux.jsonaction system.palette,ui.newWorkspace.action,ui.newWorkspace.contextMenu,ui.surfaceTabBar.buttons, andshortcutThe discovery model filters shipped built-ins unless they have a config source path, so the panel focuses on user/project customization while still surfacing built-in overrides.
Lane K / #79
Implements Lane K from teamleaderleo/Tact#79.
Lane J uses workflows / saved layouts for reusable layout discovery. This PR keeps that vocabulary intact and scopes its UI to resolved
cmux.jsonactions and their launcher placements; it does not touch Lane J's workflow catalog/docs files.Tests
Focused coverage:
CmuxConfigWorkspaceActionTests.actionsAndLaunchersDiscoveryReportsEffectivePlacementscovers agent/workspace kinds, palette/default/+ menu/tab-bar/shortcut placement, and hiding unconfigured shipped built-ins.swiftc -frontend -parse.Localization audit
No new prose localization keys were introduced. The new native UI reuses existing localized strings for Actions, Open cmux.json, Open Docs, and OK. Placement/type rows intentionally display invariant
cmux.jsonidentifiers and schema enum values so users can map the discovery view directly back to config.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds a native discovery panel for
cmux.jsonactions. Previously there was no in-app view of resolved custom actions; now an Actions · cmux.json… entry in the app menu and new-workspace menu tail shows a read-only list of resolved actions with effective placements and source paths. Built-ins are hidden unless overridden. Execution and edit paths are unchanged, and no new localization keys were introduced.Surface tab bar placement is reported per configured action and only for visible buttons, so hidden buttons are excluded and identical commands are never conflated in the panel.
Implements Lane K of #79 without touching Lane J's workflow/saved-layout vocabulary.
Tests
Written for commit fc6a118. Summary will update on new commits.