fix: clear Swift warning budget failures on main

[lawrencecchen]

Summary

• Remove the three new Swift warning-budget findings on current main.
• Preserve behavior while using the intended discard syntax, binding pattern, and non-throwing call form.

Testing

• python3 scripts/swift_warning_budget.py --log against the affected build output
• git diff --check

Context

The post-merge macOS CI run reported these warnings as new budget violations:

• CloudTreeNode.swift: ineffective let pattern
• MobileHostService+PhonePushKeyExchange.swift: unnecessary try
• CmuxTuiSurfaceProvider+AgentNaming.swift: unused connected binding

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Clears the three Swift warning budget failures currently on main without changing behavior.

• Replaces an ineffective let pattern in CloudTreeNode.swift with discard syntax.
• Removes a redundant try in MobileHostService+PhonePushKeyExchange.swift.
• Ignores an unused binding result in CmuxTuiSurfaceProvider+AgentNaming.swift.

^{Written for commit 0450761. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Corrected resource title handling without changing displayed titles.
  • Improved error propagation during phone push key exchange so underlying failures are no longer reported as invalid requests.
  • Improved agent tab rename flow by ensuring the connection check completes before subsequent updates.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6b86d10e-5b3e-4378-b81c-9783efabc254

📥 Commits

Reviewing files that changed from the base of the PR and between 3a114be and 0450761.

📒 Files selected for processing (3)

• Sources/Cloud/CloudTreeNode.swift
• Sources/Mobile/MobileHostService+PhonePushKeyExchange.swift
• Sources/Surfaces/CmuxTuiSurfaceProvider+AgentNaming.swift

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The pull request makes three isolated Swift changes: it corrects a resource pattern, changes phone push-key error propagation, and removes an unused connection-result binding.

Changes

Cloud resource title pattern

Layer / File(s)	Summary
Resource title pattern correction Sources/Cloud/CloudTreeNode.swift	The .resource pattern uses _ for the unused machine identifier. The code still returns row.title.

Phone push-key error propagation

Layer / File(s)	Summary
Pin error propagation Sources/Mobile/MobileHostService+PhonePushKeyExchange.swift	The PhonePushPeerKeyStore.pin call no longer uses try. Errors are no longer mapped to an invalid_request response by the surrounding do/catch.

Agent naming connection cleanup

Layer / File(s)	Summary
Connection result cleanup Sources/Surfaces/CmuxTuiSurfaceProvider+AgentNaming.swift	The awaited links.connected(machineID:) result is no longer stored. The connection call remains in the flow.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

Suggested reviewers: austinywang

Merge Risk: ⚪ Minimal · up to 04507

These warning-budget cleanups do not introduce a concrete production or workflow risk, so the change is mergeable.

🚥 Pre-merge checks | ✅ 24 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (24 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: resolving Swift warning-budget failures on main.
Description check	✅ Passed	The description explains what changed and why, lists the affected warnings, and documents the testing performed. The Demo Video section is not needed because this is a non-UI warning cleanup. The temp…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input	✅ Passed	PASS. The authoritative diff contains only three warning-cleanup edits. It changes a Swift pattern in CloudTreeNode.searchableTitle, removes try from PhonePushPeerKeyStore.pin, and discards the …
Cmux Swift Actor Isolation	✅ Passed	PASS: The reviewed diff changes only three expressions: a Swift pattern, removal of try, and replacement of an unused binding with _. It adds no @MainActor, nonisolated, Sendable, actor, pro…
Cmux Swift Blocking Runtime	✅ Passed	PASS: The PR changes only three existing expressions. It replaces let _ with _, removes an unnecessary try, and changes an unused binding to _ = try await. The zero-context diff introduces no …
Cmux Browser Automation Off-Main	✅ Passed	PASS: The pull request changes only three Swift warning fixes in CloudTreeNode.swift, MobileHostService+PhonePushKeyExchange.swift, and CmuxTuiSurfaceProvider+AgentNaming.swift. No changed hunk adds o…
Cmux Expensive Synchronous Load	✅ Passed	PASS. The authoritative diff contains only three one-line warning fixes. It adds no agent-history loader, file scan, transcript/trajectory read, or large JSON/JSONL parse. The renameAgentTab change …
Cmux Cache Substitution Correctness	✅ Passed	PASS: The diff does not replace an authoritative read with a cached or opportunistic value. The only change near a persistence/snapshot path changes `let connected = try await links.connected(machineI…
Cmux No Hacky Sleeps	✅ Passed	PASS. The review-scoped diff changes only three .swift files under Sources/. It introduces no TypeScript, JavaScript, shell, or non-Swift build/runtime changes, and it adds no fixed sleeps, timers…
Cmux Algorithmic Complexity	✅ Passed	The pull request changes only three single-line Swift syntax/diagnostic fixes. It replaces an ineffective pattern binding, removes try from PhonePushPeerKeyStore.pin, and discards the result of `l…
Cmux Swift Concurrency	✅ Passed	The PR changes only three existing lines. It fixes a Swift pattern, removes an unnecessary try, and changes an unused binding to _ = try await links.connected(...). The added async-related call re…
Cmux Swift @Concurrent	✅ Passed	PASS. The PR changes only Swift pattern syntax, removal of an unnecessary try, and replacement of an unused async result with _ =. No @concurrent, nonisolated async, actor isolation, or async …
Cmux Swift Package Boundaries	✅ Passed	PASS. The authoritative diff changes only three existing Swift lines, with no new types, feature logic, package manifests, targets, or files. The edits replace warning-producing syntax in an existing …
Cmux Swiftpm Lockfiles	✅ Passed	PASS. The authoritative pull-request diff contains only three Swift source-file edits: Sources/Cloud/CloudTreeNode.swift, Sources/Mobile/MobileHostService+PhonePushKeyExchange.swift, and `Sources/…
Cmux Swift Logging	✅ Passed	PASS: The authoritative diff changes only three warning-fix lines. It adds no print, debugPrint, dump, NSLog, file/stdout logging, Logger declaration, or diagnostic data logging. The logging-t…
Cmux User-Facing Error Privacy	✅ Passed	PASS: The pull request does not add or materially change user-facing error text. The authoritative diff changes only Swift syntax: let _ becomes _, try is removed from the non-throwing `PhonePus…
Cmux Full Internationalization	✅ Passed	PASS: The PR changes only Swift syntax and error-handling forms in three existing source files. The exact diff adds no user-facing text, localization key, catalog entry, web message, or locale configu…
Cmux Swiftui State Layout	✅ Passed	PASS: The pull request does not change SwiftUI state or layout. The authoritative diff contains only three one-line edits: a Swift pattern wildcard in CloudTreeNode, removal of an unnecessary try …
Cmux Architecture Rethink	✅ Passed	PASS. The review-scoped diff contains only three one-line Swift syntax/warning fixes. It adds no sleeps, delayed dispatch, polling, locks, observers, side channels, duplicate entrypoint wiring, or new…
Cmux Swift Auxiliary Window Close Shortcuts	✅ Passed	PASS. The authoritative diff changes only three existing Swift expressions: a pattern wildcard, removal of try, and an unused-result assignment. It adds or materially changes no NSWindow, `NSPanel…
Cmux Source Artifacts	✅ Passed	PASS. The authoritative diff changes only three existing, hand-written Swift source files under Sources/: Sources/Cloud/CloudTreeNode.swift, `Sources/Mobile/MobileHostService+PhonePushKeyExchange.…
Cmux No Test Or Debug Seam In Production Source	✅ Passed	PASS. The PR changes only three production Swift files, and the added lines correct a switch pattern, remove an unnecessary try, and discard a connection result. The authoritative diff adds no `#if …

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}