Repository navigation
Cloud: make New Machine creation optimistic #12919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
f40f0eb
Cloud VM startup benchmarks: control plane, provider floor, private link
austinywang ca41f28
Cloud startup latency report: baseline, lower bound, ranked plan (#12…
austinywang c3c6312
Merge remote-tracking branch 'origin/main' into 12905-cloud-startup-l…
austinywang 2019e57
Report: count the attach-time shim/opener check added by #12741
austinywang 8b64885
Benchmarks: fail closed on cleanup, readiness, statuses, and interrupts
austinywang 057872f
Benchmarks: bound every wait by its budget, reject no-op runs
austinywang deb7863
API benchmark: never orphan a create, prove each readiness sample
austinywang 7dc5c29
Benchmarks: reconcile by run identity so a lost create never orphans …
austinywang e6821a0
Cloud: make new machine creation optimistic
austinywang cef7037
Benchmarks: no public daemon ingress, provable readiness, full accoun…
austinywang 26fd7e8
Report: incidental findings (double allocation, owner-network leaks, …
austinywang 26b9a0f
Benchmarks: verify provider inventory, size the session, page and fai…
austinywang a4c1700
Benchmarks: keep partial inventory, page to totalCount, read the acco…
austinywang 96ca146
API benchmark: keep the user after an unclassified account failure, b…
austinywang 0a39687
Benchmarks: bound SDK awaits, stop the prompt clock before teardown, …
austinywang 07cecb4
Benchmarks: reconcile networks and tunnels by slug, delete a session-…
austinywang 0dd67ba
Benchmarks: settle in-flight provider requests before reconciling; wa…
austinywang 2a6884c
Benchmarks: keep the identity for the app's resumable account deletio…
austinywang 5ae92f4
Benchmarks: fail closed on an unknown identity; never abandon in-flig…
austinywang 6d217f8
Benchmarks: resolve ambiguous creates, bound every teardown SDK call,…
austinywang b521e3a
Benchmarks: interruptible finalizer timeouts, bounded attach, typed v…
austinywang d8f8582
Benchmarks: give the transport benchmark production's inputs; fix the…
austinywang 3e64976
Benchmarks: accept the runtime's provider credential forms, fill sens…
austinywang 98805d4
Benchmarks: verify a --url deployment belongs to the project before s…
austinywang 7ca7c62
Benchmarks: prove slug ownership before any slug-based deletion
austinywang d0eb458
Benchmarks: fail closed on a slug conflict; time only the daemon boun…
austinywang 390c7c8
Report: cite the re-measured allocation in the transport narrative an…
austinywang e600a94
Benchmarks: slug recovery only for a lost create, unresolved creates …
austinywang c3febf3
Benchmarks: delete the known network again after recovering a lost tu…
austinywang 06fd621
Benchmarks: re-sweep machines after settling; a tunnel recovered unde…
austinywang 766c7f9
Benchmarks: only a conflict proves a create did not happen; never exi…
austinywang 53da7f3
Benchmarks: never take an empty user search as proof after a lost cre…
austinywang e8c46a1
Benchmarks: probe the deployment's edge alias; scope the transport be…
austinywang 8955101
Benchmarks: never sweep past an in-flight provider request; run a fai…
austinywang c1b5b69
Benchmarks: bound the API benchmark's provider client; previews need …
austinywang 48691b9
Benchmarks: refuse an image without the identity marker; report: the …
austinywang e7b4868
Benchmarks: name the create-plus-attach sum for what it is
austinywang f7bcea0
Benchmarks: bound every ambiguous-create re-post by the route's remai…
austinywang 7c4231a
Benchmarks: bound the Stack calls; mark a run's network independently…
austinywang 18f67e0
Benchmarks: a 5xx create is ambiguous; size the session to the reques…
austinywang 7ee01a0
Benchmarks: one bounded provider client for all three; resolve create…
austinywang f224da0
Benchmarks: an abandoned background request is unresolved cleanup; de…
austinywang d543449
Benchmarks: a background request is outstanding until its answer is s…
austinywang d0a200d
Benchmarks: record a created network's and tunnel's id on the request…
austinywang cfbf49d
Merge origin/main into optimistic machine creation
austinywang a1610d7
test: expose pending machine identity and recursive close regressions
austinywang 8a19388
Merge branch 'main' into 12905-cloud-startup-latency
lawrencecchen d2ad79f
fix: own optimistic machine lifecycle and stable adoption in Cloud pa…
austinywang 2f117d8
test: unblock hosted verification and refresh merged iOS fixtures
austinywang 134efbd
ci: route Cloud lifecycle tests through the shared runner setting
austinywang 4387f23
test: expose machine placement deferred until provisioning completes
austinywang cf0892b
fix: place new machine reservations before asynchronous provisioning
austinywang a64d338
Merge remote-tracking branch 'origin/pr-12911' into 12904-optimistic-…
austinywang f94d2bf
test: require create-time naming and idempotent display-name persistence
austinywang adc24fb
fix: return the extracted Base loading content
austinywang 39ac104
perf: name machines during create and reuse matching client artifacts…
austinywang 47d6f83
fix: pass reserved machine name into provider create
austinywang 8c16a11
test: type check create-time naming coverage
austinywang 18d63e1
refactor: keep Cloud VM create complexity within the gate
austinywang 2bb9aa1
test: require an attested cmux-tui manifest before installing a publi…
austinywang ef3fe4a
ci: verify the published cmux-tui manifest's build-provenance attesta…
austinywang 131581d
test: expect a localized vm_invalid_request for an unusable display name
austinywang 522d2db
fix: localize the Cloud VM display-name rejection and answer it as vm…
austinywang abdf704
test: pin the profile-expiry clock, drop the CLI naming wall-clock ce…
austinywang 891ac21
Merge origin/main (9f29ddfc77a) into 12904-optimistic-machine-creation
austinywang f3c4d46
test: expect every remote cmux-tui install to verify the publisher's …
austinywang 01cb4b3
ci: verify the cmux-tui manifest attestation on every remote install …
austinywang 6f16e1a
Merge branch 'main' into 12904-optimistic-machine-creation
lawrencecchen f819895
test: keep the create-time naming test importable on Python 3.9
austinywang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: Cloud machine lifecycle | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - Packages/macOS/CmuxCloudMachines/** | ||
| - .github/workflows/cloud-machine-tests.yml | ||
| workflow_dispatch: | ||
| inputs: | ||
| runner: | ||
| description: Optional hosted macOS runner label | ||
| required: false | ||
| default: "" | ||
| type: string | ||
| ref: | ||
| description: Source ref to test | ||
| required: false | ||
| default: "" | ||
| type: string | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: cloud-machine-tests-${{ github.ref }} | ||
| cancel-in-progress: ${{ github.event_name == 'pull_request' }} | ||
|
|
||
| jobs: | ||
| lifecycle: | ||
| runs-on: ${{ inputs.runner || vars.MACOS_RUNNER_15 || 'blacksmith-6vcpu-macos-15' }} | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| ref: ${{ inputs.ref || github.ref }} | ||
| - name: Select Xcode | ||
| run: ./scripts/select-ci-xcode.sh | ||
| - name: Test the package without launching the app | ||
| run: swift test --package-path Packages/macOS/CmuxCloudMachines -Xswiftc -warnings-as-errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.