Skip to content

Allow deleting non-Iroh mobile routes - #12691

Merged
azooz2003-bit merged 2 commits into
mainfrom
feat-delete-non-iroh-routes-2
Sep 15, 2026
Merged

azooz2003-bit merged 2 commits into
mainfrom
feat-delete-non-iroh-routes-2

Conversation

@azooz2003-bit

@azooz2003-bit azooz2003-bit commented Sep 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • remove Connection Check, Presence, Ping, stale route diagnostics, and reconnect troubleshooting actions from Computer Details
  • keep route management and Tailscale pairing rescan available
  • allow deleting non-Iroh routes, including the final saved route, while retaining the computer record
  • preserve removal tombstones so deleted routes do not reappear after restart
  • include the supporting macOS compile fixes required by this branch build

Verification

  • tagged macOS build completed for nirho8
  • tagged iOS simulator build completed and paired dogfood exercised
  • 17 screenshot evidence report: /Users/abdulazizalbahar/Dev/Manaflow/cmuxterm-hq/artifacts/feat-delete-non-iroh-routes-2/route-proof/index.html
  • verified live iOS-to-Mac terminal command and route persistence after restart

Known follow-up: Computer Details can temporarily display Not connected while the Iroh terminal session remains usable. This is documented in the evidence report and is outside the route deletion behavior changed here.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Removes Connection Check, Presence, Ping, stale route diagnostics, and Reconnect from Computer Details, and lets you delete non-Iroh routes even when it's the last saved route without deleting the computer record.

Behavior

  • Deleting the last saved route leaves the computer with no saved routes and preserves the removal tombstone, so the route doesn't reappear after restart.
  • The Routes section now always offers Tailscale pairing, for both setup and replacement.

Notes

  • Includes the macOS compile fixes required by this branch build.
  • Known follow-up: Computer Details can temporarily show Not connected while the Iroh terminal session remains usable.

Written for commit 1e6a68e. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes

    • Removing the final route now correctly records the removal, revokes associated access, refreshes computer activity, and cleans up route data.
    • Final-route removal no longer depends on an optional deletion setting.
  • User Interface

    • Simplified computer details by removing connection-status and route-ping indicators.
    • Added a “Forget Computer” confirmation and failure alert.
    • Streamlined route management and made Tailscale pairing available from the computer details view.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f56cd395-20b9-426d-9686-c595d70402c2

📥 Commits

Reviewing files that changed from the base of the PR and between 0447a31 and 1e6a68e.

📒 Files selected for processing (4)
  • Packages/iOS/CmuxMobilePairedMac/Sources/CmuxMobilePairedMac/MobilePairedMacStore.swift
  • Packages/iOS/CmuxMobileShell/Sources/CmuxMobileShell/MobileShellComposite+RouteRemoval.swift
  • Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/MacComputerDetailView.swift
  • Sources/Cloud/CloudTreeRowContentView.swift
 ______________________________________________________
< Plot twist: Your tests were the real bugs all along. >
 ------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat-delete-non-iroh-routes-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 15, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@azooz2003-bit
azooz2003-bit enabled auto-merge (squash) September 15, 2026 18:57
@azooz2003-bit
azooz2003-bit merged commit 6052c56 into main Sep 15, 2026
15 of 17 checks passed
rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 15, 2026
6052c56 Allow deleting non-Iroh mobile routes (manaflow-ai#12691)
0447a31 Stop internal memory pressure diagnostics from creating notifications (manaflow-ai#12667)
@austinywang austinywang mentioned this pull request Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant