Repository navigation
Allow deleting non-Iroh mobile routes - #12691
Merged
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
azooz2003-bit
enabled auto-merge (squash)
September 15, 2026 18:57
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 15, 2026
6052c56 Allow deleting non-Iroh mobile routes (manaflow-ai#12691) 0447a31 Stop internal memory pressure diagnostics from creating notifications (manaflow-ai#12667)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
nirho8/Users/abdulazizalbahar/Dev/Manaflow/cmuxterm-hq/artifacts/feat-delete-non-iroh-routes-2/route-proof/index.htmlKnown follow-up: Computer Details can temporarily display
Not connectedwhile the Iroh terminal session remains usable. This is documented in the evidence report and is outside the route deletion behavior changed here.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Removes Connection Check, Presence, Ping, stale route diagnostics, and Reconnect from Computer Details, and lets you delete non-Iroh routes even when it's the last saved route without deleting the computer record.
Behavior
Notes
Not connectedwhile the Iroh terminal session remains usable.Written for commit 1e6a68e. Summary will update on new commits.
Summary by CodeRabbit
Bug Fixes
User Interface