Repository navigation
fix: remove stale Codex resume helper call - #12659
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Codex wrapper no longer emits a synthetic session-start event when resuming a session. Shared tests now require empty stderr and no ChangesCodex resume hook behavior
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The wrapper now relies on injected hook arguments and removes the stale resume helper without an identified regression. 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
922394a Allow switching accounts on CLI authorization (manaflow-ai#12679) 8bde8e2 fix: remove stale Codex resume helper call (manaflow-ai#12659)
codex --yoloprintscmux_codex_resume_session_id: command not foundon cmux 0.64.23 because an obsolete resume startup block was restored without its deleted helper. Remove the block so Codex's injected hooks remain the source of session identity.The regression test rejects startup stderr and synthetic session-start calls. The test and fix remain separate commits. The branch is updated with current main, which contains the correction for the unrelated
PendingRemoteRenameaccess-level compilation error.Validation:
--yolo; this fix preserves the argument and injected hooks with empty stderr.env -i PATH="$PATH" TMPDIR="$TMPDIR" python3 tests/test_codex_wrapper_computer_use_mcp.pypasses.bash -n Resources/bin/cmux-codex-wrapperandgit diff --checkpass.codex --yoloopens Codex 0.154.0 without the missing-function error in tagcdx650, workspace:1/surface:2, through/tmp/cmux-debug-cdx650.sock. Screenshot captured and inspected.Dogfood: open tag
cdx650and runcodex --yoloin its terminal. Codex should start without the missing-function message.Closes #12650