Repository navigation
chore: remove Cloud provider Release compile guard - #12571
Merged
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe pull request deletes the cloud-provider Release compile guard workflow and all of its setup, caching, dependency resolution, and build steps. ChangesCloud-provider release guard removal
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to No verified merge-blocking issue remains. 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
Full details: Description checkResolution Add the required Testing, Demo Video, Review Trigger, and Checklist sections. Document the tests and manual verification performed, state whether a demo video is not applicable, include the review trigger block, and complete each checklist item or explain why it does not apply.
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 14, 2026
4638e5b Merge pull request manaflow-ai#12570 from manaflow-ai/issue-7272-undo-stack-crash 61eedef fix: isolate web undo targets before app menu routing c83dc7f Merge pull request manaflow-ai#12562 from manaflow-ai/issue-12532-agent-notification-flaky bfe1d3f Merge pull request manaflow-ai#12571 from manaflow-ai/issue-12547-nightly-provider-duplicates-guard f0d1635 chore: remove Cloud provider Release compile guard 509e806 Merge pull request manaflow-ai#12569 from manaflow-ai/issue-12567-cloud-machine-connectivity a5410da diagnostics(cloud): correlate machine terminal attachment state 7f6de01 test: reproduce application and markdown undo lifetime crashes 720f24a fix: close contextual signal matcher 50e3416 test: preserve numeric crash signal diagnosis d21502d test: exercise selected semantic suite reporting 3a0aff2 fix: retain contextual signal crash markers 16b9e75 test: preserve contextual signal crash diagnosis 557bb90 fix: trigger semantic workflow for classifier changes 46f0ba7 test: cover non-crash signal text 3824276 fix: avoid matching build signatures as signals 7079066 test: ignore build signatures in app-host causes # Conflicts: # .github/workflows/agent-notification-tests.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12568.
Remove the dedicated Cloud provider Release compile guard at the user’s request. The provider ownership repair remains on
mainfrom #12568; this follow-up deletes only the extra CI/CD workflow that duplicated the already-successful Nightly universal Release workload.Trade-off: autoreview identified that this workflow was the only pre-merge macOS Release coverage for these Cloud provider paths. That P1 finding is consciously accepted because the requested outcome is to remove this long-running CI/CD test; Nightly remains the post-merge Release gate.