Skip to content

Cloud shortcuts inherit the active remote working directory - #12450

Merged
austinywang merged 2 commits into
mainfrom
issue-12448-cloud-directory-inheritance
Sep 13, 2026
Merged

austinywang merged 2 commits into
mainfrom
issue-12448-cloud-directory-inheritance

Conversation

@austinywang

@austinywang austinywang commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Cloud keyboard shortcuts that create a terminal, tab, or split start the new remote shell in the machine home directory instead of the active source terminal's current remote directory.

Change

Cloud shortcut routing now queries cmux-tui's live foreground process cwd for the exact projected source terminal, then passes that path through the existing same-machine/workspace terminal creation request. The recorded spawn cwd is intentionally ignored because it is stale after a remote cd; unavailable or empty live reports preserve the existing daemon fallback. Local and SSH creation paths are unchanged.

Validation

  • Added a behavior regression covering Cloud tab creation from a projected terminal with distinct spawn and live directories, including exact remote workspace routing.
  • Added coverage for the terminal … process show argv and foreground cwd parsing.
  • python3 scripts/swift_file_length_budget.py
  • ./scripts/lint-pbxproj-test-wiring.sh
  • python3 scripts/check-package-resolved-policy.py

Closes #12448


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Cloud shortcuts that create a terminal, tab, or split now start the new remote shell in the source terminal's live remote working directory instead of the machine home directory.

Written for commit dee7906. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cmux166 Ready Ready Preview Sep 13, 2026 6:46am UTC
cmux41 Ready Ready Preview Sep 13, 2026 6:46am UTC

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2cbaa9cd-2ae5-4552-9d70-470fe2e87464

📥 Commits

Reviewing files that changed from the base of the PR and between bf8a24f and dee7906.

📒 Files selected for processing (5)
  • Sources/Cloud/CloudTuiCommandLine.swift
  • Sources/Surfaces/CmuxTuiSurfaceProvider+TerminalIO.swift
  • Sources/Surfaces/SurfaceProvider.swift
  • Sources/Surfaces/Workspace+CloudPaneRouting.swift
  • cmuxTests/SurfacePaneFactoryFocusTests.swift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@austinywang
austinywang enabled auto-merge (squash) September 13, 2026 04:24
@austinywang
austinywang merged commit d21e961 into main Sep 13, 2026
19 of 23 checks passed
rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 13, 2026
f774e9e Merge pull request manaflow-ai#12461 from manaflow-ai/issue-12451-browser-download-history
0fe1194 Merge pull request manaflow-ai#12459 from manaflow-ai/fix-workspace-switch-hang
27cd79f Merge pull request manaflow-ai#12414 from manaflow-ai/issue-12393-workspace-switch-ghosting
f7a8a74 Merge pull request manaflow-ai#12343 from manaflow-ai/issue-8539-terminal-input-routing
8d7c575 Merge pull request manaflow-ai#12294 from manaflow-ai/issue-12291-cloud-badge-sidebar
2a0db5c fix: validate browser history dispatch inputs
ef76e26 fix: repair inherited Cloud banner initializer compile
475d483 Merge branch 'main' of https://github.com/manaflow-ai/cmux into issue-12291-cloud-badge-sidebar
ef69225 fix: validate and localize download CLI output
d9e50ca Merge pull request manaflow-ai#12471 from manaflow-ai/issue-12456-nightly-build-failures
a1879f0 Merge pull request manaflow-ai#12440 from manaflow-ai/issue-12438-cloud-restore-names
a10d915 fix: restore nightly Release build
d651f89 Merge pull request manaflow-ai#12442 from manaflow-ai/issue-12406-cloud-vm-resize
06baed1 Merge remote-tracking branch 'origin/main' into issue-12451-browser-download-history
ad66765 Merge branch 'main' of https://github.com/manaflow-ai/cmux into issue-12438-cloud-restore-names
abffeec fix: harden Option input and terminal link routing
aa77399 Merge latest origin/main and resolve conflicts
36cd2ea Merge main and keep its configured Cloud destination default
b178b2a Merge pull request manaflow-ai#12382 from manaflow-ai/issue-12362-cloud-terminal-reliability
ae85ea0 fix: make mobile identity cache immutable
d21e961 Cloud shortcuts inherit the active remote working directory (manaflow-ai#12450)
aa04bec Merge branch 'main' of https://github.com/manaflow-ai/cmux into fix-workspace-switch-hang
9686d25 Merge pull request manaflow-ai#12455 from manaflow-ai/issue-12232-notification-semantics-failures
8986afc docs: surface browser download history in cmux skill
5bdcb7e Merge pull request manaflow-ai#12418 from manaflow-ai/issue-12407-cloud-vpn-banner
e49df52 fix: preserve legacy download paths
93cdefc Fix ungrouped Cloud workspace destination defaults
59f7a9a fix: format browser download status values
d89a8e3 fix: complete post-merge app and test guards
2d723ab fix: restore cloud workspace destination fallback
2e6f92e Verify stored Codex ownership before metadata migration (manaflow-ai#12460)
9011d8a refactor: keep download history snapshot helpers focused
2ac102d test: follow the CmuxMain app entry point
f97f1e9 feat: expose browser download history in CLI
d710760 ci: retrigger preview deployments
b19a245 fix: cache mobile identity before terminal dismissal
a17f242 test: register Cloud rename provider and verify tab clear delivery
324a366 fix: narrow image ladder fixture type
6139d23 Merge remote-tracking branch 'origin/main' into issue-12291-cloud-badge-sidebar
ea9d3f7 Validate explicit sidebar themes and collect focused suite failures
fe0ae8f fix: derive pending Cloud workspaces from resource overlays
99f1090 test: cover stale workspace summaries with pending creation overlays
0edd568 fix: use valid ungrouped Cloud action destination defaults
9feae9e Merge origin/main and resolve Cloud VM resize conflicts
3aa63f0 fix: repair resize CI fixtures and normalize Xcode project
fc855f4 Merge origin/main into issue-12407-cloud-vpn-banner
f7c88b5 test: cover browser download list CLI
cd7d25c test: observe Claude hook process termination directly
a14c7f5 Merge main and retain both Cloud project registrations
17d41d7 fix: address Cloud VPN banner review findings
b976fd9 ci: pin Bun for notification test lane
bd549b0 fix: retain post-projection outcomes and synchronize resolver tests
d11f8c3 Simplify sidebar focus setup
d9df088 Keep sidebar focus fixture scoped to boundary ownership
4879d30 Avoid empty popover invalidation on sidebar reveal
fa4bdcf test: separate nested Swift Testing assertions
68ef25a test: align cloud VM expectations with current limits
73a9ef3 fix: expose cloud materialization state to lifecycle extension
10df628 test: share one cloud manual mirror socket fixture after merge
02eb05d fix: restore web typecheck compatibility
41df519 test: await Cloud provider cleanup in restore regressions
6ea1830 Release hidden sidebar payloads and stabilize focus fixtures
f1d9ef7 feat: expose Cloud VM resource resizing across clients
f8d107e build: locate cloud attachment panel sources in Panels
3fe0398 fix: preserve Cloud names across checkpoints and restore refreshes
b9c64ab build: quote Swift extension paths in Xcode project
f80490b test: cover Cloud checkpoint names across restore and refresh
ff273b7 fix: address cloud attachment recovery review feedback
25406dc test: cover cloud attachment review regressions before fixes
cd1581a Merge main and preserve cloud attachment recovery and diagnostics
26e7602 test: cover Cloud VM resize route contract
32f4a49 Give Cloud binding one observable state owner
d8a6903 Use bounded async Cloud sidebar invalidation
3d5b003 Merge remote-tracking branch 'origin/main' into issue-12291-cloud-badge-sidebar
7f8d53c feat: support plan-aware Cloud VM resource resizing
b95d08f Clarify optional Cloud VPN access
a81d39e fix: gate stale workspace portals by lifecycle owner
9fae811 test: cover inactive workspace portal authorization
3925503 test: require Cloud VM disk resize menu action
023f45a cloud: always attach live terminals, retry slow daemons, recover wedged attachments
351cbe0 test: cloud terminal attachment regressions for manaflow-ai#12362 (red)
de8af41 cloud: seam for the terminal attachment resolver (no behavior change)
7624d70 Avoid duplicate sidebar projection on reveal
c824b97 test: wait for Cloud sidebar invalidation signal
d28fe2a fix: link terminal core into the CLI target
84f7248 Fix shared Cloud sidebar refresh path
2cf9477 test: cover Cloud sidebar refresh after hidden reveal
5b347c6 fix: expose Finder reveal for browser local files
28c32bd style: normalize Dock link split call
5f2c4f7 fix: route claimed Option input and terminal links coherently
ccf9650 test: cover all claimed Option dead-key combinations
bfbc7bb test: reject unmatched and stale terminal link gestures
f65a379 fix: resolve Dock terminal link identities through panel ownership
4ee15ed test: cover Dock control terminal link routing
952df1e Address review findings before merge
8616849 Make terminal file locations openable
5350b7f Add regression coverage for terminal file locations
be812c7 Hide sidebar accessory when symbol rendering fails
b497398 Fix Cloud sidebar observation review findings
2475be7 Cover Cloud badge updates during sidebar context menus
da19d21 Extract Cloud badge helpers and focused behavior suite
9857fc7 Show persistent Cloud identity in sidebar row accessories
b72a7a9 test: cover Cloud workspace sidebar identity and badge

# Conflicts:
#	.github/workflows/ci.yml
#	.github/workflows/test-depot.yml

This branch was successfully deployed

2 active deployments
Preview – cmux41 — dee79066 Deployed Sep 13, 2026 by vercel[bot]
Preview – cmux166 — dee79066 Deployed Sep 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cmux Cloud: new terminal shortcuts do not inherit the active remote working directory

1 participant