Skip to content

cmux-tui: pass the zig target on a native windows-gnu host #12416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 2 commits into from
Sep 27, 2026
Merged

cmux-tui: pass the zig target on a native windows-gnu host #12416

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ff7b32
cmux-tui: pass the zig target on a native windows-gnu host
Somuuuu007 Sep 12, 2026
5a0009a
Merge main into cmux-tui-windows-gnu-zig-target
teamleaderleo Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmux-tui/crates/ghostty-vt-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,12 @@ fn main() {
.arg("-Demit-lib-vt=true")
.arg("-Demit-xcframework=false")
.arg("-Doptimize=ReleaseFast");
if target != host
// Pass the target whenever we know it, not only when cross-compiling.
// zig defaults to the msvc ABI on Windows, so a native *-windows-gnu
// host (no Visual Studio, e.g. a rustup gnu toolchain with MSYS2) would
// otherwise get `-target native-native-msvc` and fail the zig build with
// "failed to find libc installation: WindowsSdkNotFound".
if (target != host || target.contains("windows-gnu"))
&& let Some(zig_target) = zig_target_for_rust_target(&target)
{
command.arg(format!("-Dtarget={zig_target}"));
Expand Down
Loading