Skip to content

fix: preserve Codex activity in Dock tabs - #12333

Merged
azooz2003-bit merged 1 commit into
issue-10217-codex-tab-spinnerfrom
pr11743-clean
Sep 11, 2026
Merged

azooz2003-bit merged 1 commit into
issue-10217-codex-tab-spinnerfrom
pr11743-clean

Conversation

@azooz2003-bit

@azooz2003-bit azooz2003-bit commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator

This in-org replacement supersedes #11743.

Preserves Codex activity markers and stable title ownership for Dock tabs through transfers, restore, rename, and follow-up child activity. Includes focused lifecycle and ownership coverage.

The replacement is based on the current stacked base and contains only the feature delta, with the external-fork conflict resolved.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Note

Medium Risk
Changes Dock tab title resolution, persistence, and cross-container transfers for terminal/Codex panels; regressions could mis-save titles or lose activity indicators, but scope is UI/state sync rather than security-critical paths.

Overview
Dock terminal tabs now project Codex lifecycle state (running spinner, idle prefix, etc.) onto the visible Bonsplit title while keeping a stable underlying title for persistence, detach/attach, and rename.

Title ownership and reconciliation

  • Tracks per-panel custom title source (user vs auto) through session restore, transfer adoption, rename, and panel teardown.
  • Adds stableDockTerminalTabTitle and reconcileCodexTabTitlePresentation so transient Codex markers are stripped when resolving transfers/snapshots and re-applied when agent runtime changes, terminal titles update, or surfaces attach to the Dock.
  • Rename uses the stable title in the dialog; clearing/setting a custom title updates provenance and re-reconciles presentation.

Transfer and terminal sync

  • Detach metadata resolution prefers stable tab titles for terminals; DetachedSurfaceTransfer title/cachedTitle are mutable so admitted terminal titles can refresh transfer snapshots without baking in decorations.
  • Terminal title sync paths route through reconciliation instead of copying displayTitle directly onto the tab.

Tests

  • Expands CodexTabTitlePresentationTests for Dock round-trips, lifecycle + rename interactions, restore boundaries, auto/user titles, and remote-titled tabs.

Reviewed by Cursor Bugbot for commit 86e1fd6. Bugbot is set up for automated code reviews on this repo. Configure here.


Summary by cubic

Preserves Codex activity markers and stable title ownership on Dock tabs through transfers, restore, rename, and lifecycle updates, so spinners and idle indicators no longer get lost or stuck.

Dock title reconciliation

  • Tracks custom-title provenance (user vs auto) through transfers and session restore.
  • Re-runs Codex title projection on lifecycle changes, rename, attach/detach, and terminal title updates.
  • Renaming a running auto-titled tab keeps the running indicator on the stable title.
  • Persisted snapshots record custom-title source and remote-title protection for correct restoration.

Written for commit 86e1fd6. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cmux166 Ready Ready Preview Sep 11, 2026 8:35pm UTC
cmux41 Ready Ready Preview Sep 11, 2026 8:35pm UTC

@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7ea331c8-a273-4d71-9d52-856c79b46901

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@azooz2003-bit
azooz2003-bit merged commit dc4ae61 into issue-10217-codex-tab-spinner Sep 11, 2026
20 of 21 checks passed
@azooz2003-bit
azooz2003-bit deleted the pr11743-clean branch September 11, 2026 20:36

This branch was successfully deployed

2 active deployments
Preview – cmux166 — 86e1fd6e Deployed Sep 11, 2026 by vercel[bot]
Preview – cmux41 — 86e1fd6e Deployed Sep 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant