Skip to content

Follow-up: align Codex theme defaults and prevent terminal surface bleed - #12295

Merged
austinywang merged 4 commits into
issue-12204-inactive-pane-colorsfrom
fix/codex-default-theme-compositing
Sep 11, 2026
Merged

austinywang merged 4 commits into
issue-12204-inactive-pane-colorsfrom
fix/codex-default-theme-compositing

Conversation

@austinywang

@austinywang austinywang commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #12210. Fresh installs now use Catppuccin Latte/Mocha for adaptive terminal colors. Terminal surfaces remain clipped to their panes during portal resizing and rebinding, and their dimensions come from the actual scroll viewport, including space reserved for a legacy scrollbar. Existing user Ghostty settings retain precedence.

Verification also corrected an existing scrollback test fixture to provide the authoritative scrollbar snapshot required by the current input path. Its original assertions remain intact; this is a test-only adjustment.

Validation:

  • Tagged build succeeded and installed for pushed HEAD 0df0b5b6e5.
  • Xcode Release package test run: 312 tests in 55 suites passed.
  • Built app bundles both Catppuccin palettes, byte-identical to the checked-in resources.
  • Fleet runtime check: three terminals with a focused browser survived 12 window resizes and workspace switching; terminal output and live geometry remained intact. Before/after screenshots show containment and full inactive-pane contrast.
  • Final macOS 15 GhosttySurfaceOverlayTests run: https://github.com/manaflow-ai/cmux/actions/runs/34558113554 (pending).
  • Test wiring, package-lock policy, and whitespace checks passed. Localization audit found no new user-facing strings.

Production requires the normal macOS app release. No backend deployment, database migration, secret, or feature-flag change is needed. Managed defaults apply only when adaptive defaults are enabled and the user's effective Ghostty configuration has no directives.

@vercel

vercel Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cmux166 Ready Ready Preview Sep 11, 2026 2:42am UTC
cmux41 Ready Ready Preview Sep 11, 2026 2:42am UTC

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 324d38ff-6686-4eec-b457-0a6e7aa1ae8a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@austinywang
austinywang merged commit 18e6282 into issue-12204-inactive-pane-colors Sep 11, 2026
22 of 23 checks passed
rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 11, 2026
72ce5e9 Merge pull request manaflow-ai#12210 from manaflow-ai/issue-12204-inactive-pane-colors
39bbf00 feat(web): add Founding Chromium Engineer role to jobs page (manaflow-ai#12248)
a34d44c devbox: promote sh-cd099a44912648399e0420df9b4e7f4f (daemon 897bb7a, theme-portable attach) (manaflow-ai#12304)
021537a fix: keep main windows out of fullscreen tiling (manaflow-ai#12298)
24125c7 test: update managed appearance snapshots for Catppuccin
a5a3c0f fix: match fallback colors to managed Catppuccin themes
c042f83 test: cover Catppuccin colors without theme resources
4916e7c test: use authoritative scrollbar response in wheel regression
3774a64 Complete macOS localization parity and validate plural catalogs (manaflow-ai#12169)
897bb7a Cloud panes: keep the local Ghostty theme on attach (manaflow-ai#12259)
cde2e36 web: drop the status read after Freestyle create and warm the database during auth (manaflow-ai#12260)
18e6282 Merge pull request manaflow-ai#12295 from manaflow-ai/fix/codex-default-theme-compositing
fe2292b fix: align managed terminal defaults with Codex theme
27bbb39 test: require the Codex Catppuccin default theme
84283f4 fix: size terminal frames from the tiled clip viewport
caee136 fix: keep portal terminal contents clipped during resize
454bd7a fix: preserve inactive terminal colors by default
e577aa7 test: cover inactive split appearance defaults

# Conflicts:
#	.github/workflows/ci.yml

This branch was successfully deployed

2 active deployments
Preview – cmux166 — fe2292bf Deployed Sep 11, 2026 by vercel[bot]
Preview – cmux41 — fe2292bf Deployed Sep 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants