Add settings to disable pane ring and flash - #1217
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
Greptile SummaryThis PR adds a user-facing toggle in the Notifications section of Settings to disable the blue unread-notification ring drawn around terminal panes. The implementation gates the Key changes:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User toggles Unread Pane Ring in SettingsView] -->|writes| B["UserDefaults: notificationPaneRingEnabled"]
B -->|AppStorage binding| C[TerminalPanelView reads notificationPaneRingEnabled]
C --> D{hasUnreadNotification AND notificationPaneRingEnabled?}
D -->|true| E[showsUnreadNotificationRing = true - Blue ring visible]
D -->|false| F[showsUnreadNotificationRing = false - Blue ring hidden]
subgraph DeadCode [Unused in Production]
G["NotificationPaneRingSettings.isEnabled(defaults:)"]
H[Unit Tests only]
G --> H
end
Last reviewed commit: 75e8784 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
lawrencecchen
changed the title
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR introduces two new notification UI feature flags—Pane Ring and Pane Flash—with accompanying localization strings, settings enums for UserDefaults-backed configuration, AppStorage integration in the SettingsView, and conditional logic across panel implementations to gate animations based on the new settings. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Sources/cmuxApp.swift`:
- Around line 3515-3517: The Toggle controls currently use an empty label string
and .labelsHidden(), making them inaccessible to VoiceOver; update the Toggle
initializers (the ones bound to notificationPaneRingEnabled and the other toggle
at the following instance) to provide a semantic accessibility name by either
supplying a Text label (e.g., Text("Notifications: Ring") or appropriate short
title) as the first parameter or keep the empty label but add
.accessibilityLabel("...") with a descriptive string; ensure you update both
Toggle("", isOn: $notificationPaneRingEnabled) and the other Toggle("", isOn:
...) so the accessibility label matches the visible row title.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cc57a91c-a937-4b32-baa7-5a19bfe5a0e6
📒 Files selected for processing (8)
Resources/Localizable.xcstringsSources/Panels/BrowserPanel.swiftSources/Panels/MarkdownPanel.swiftSources/Panels/TerminalPanel.swiftSources/Panels/TerminalPanelView.swiftSources/TerminalNotificationStore.swiftSources/cmuxApp.swiftcmuxTests/UpdatePillReleaseVisibilityTests.swift
…isable-blue-outline # Conflicts: # Sources/cmuxApp.swift # cmuxTests/CmuxWebViewKeyEquivalentTests.swift
bn-l
pushed a commit
to bn-l/cmux
that referenced
this pull request
Apr 3, 2026
* Add setting to disable unread pane ring * Add setting to disable pane flash * Label notification toggles for accessibility * Clean up notification settings review follow-ups
This was referenced Apr 6, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
./scripts/setup.sh(reused cached GhosttyKit.xcframework and fixed the worktree setup)./scripts/reload.sh --tag blue-outline(build succeeded and launched the tagged app after both changes)Issues
Summary by CodeRabbit