Promote devbox images baked from main - #12127
Closed
lawrencecchen wants to merge 1 commit into
Closed
lawrencecchen wants to merge 1 commit into
lawrencecchen wants to merge 1 commit into
Conversation
Both ladders rebaked so the shell config that has been sitting on main reaches machines: Option+Backspace word delete (#12099) and the Dockerfile change that preceded it. The old defaults were baked from 39bfc41, which lives only on feat-vm-guest-trust-dead-code and never landed on main. base ladder from 9cbdb7c, master sh-4b2e52f8a9584e2c9ca878c6e387e734 desktop ladder from 5a16fbb, master sh-b674df20b1534084bccec193e3e4ce18 Each entry is verified: promote boots a machine from the snapshot, and the size derive boots and checks every derived one. Agent pins are unchanged across the rebake (claude 2.1.252, codex 0.151.0, opencode 1.18.25, pi 0.84.4, agent-browser 0.35.2), so this carries no agent upgrade.
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe image manifest removes default status from all trust4 devbox images and adds twelve timestamped base and desktop images as the new defaults. The smallest new base image is also marked as the local development default. ChangesDevbox Image Defaults
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to New Devbox base and desktop images become the defaults while preserving all size options and the local-development base default. No concrete current-head merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Superseded: the manifest moved past this rebake with #12125 (termid), #12243 (wsboot), #12250 (agents0910), all baked from main, and this branch now conflicts on manifest.json. The only leftover is the human-facing slug repoint (cmux-devbox-lg and friends), which needs a --replace-slug run, not this PR. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebakes both ladders so the image source that has been sitting on main finally reaches machines: the Option+Backspace word-delete fix (#12099) and the Dockerfile change that preceded it. The previous defaults were baked from
39bfc41fad, a commit that exists only onfeat-vm-guest-trust-dead-codeand never landed on main.9cbdb7ca84sh-4b2e52f8a9584e2c9ca878c6e387e7345a16fbb6dcsh-b674df20b1534084bccec193e3e4ce18The two sit on different commits because main moved during the run and the stale-checkout guard refused the second bake until the tree was updated. That commit touched no image inputs, so both ladders are content-current; kinds are promoted separately by design.
Every entry is verified: promotion boots a machine from the master snapshot and checks it, and the size derive boots and checks each derived snapshot before recording its id.
Agent pins are unchanged across this rebake (claude-code 2.1.252, codex 0.151.0, opencode 1.18.25, pi 0.84.4, agent-browser 0.35.2), so it carries no agent upgrade to review. That is the field worth reading on any future promotion, since a bake resolves those at build time.
Measured while producing this, on the base ladder: 784s end to end, of which bake 199s, verify 131s, and six serial size derives 453s. The config file drops that made this promotion necessary are under three seconds of that.
One known gap: the derive could not move the human-facing slugs (
cmux-devbox-lgand friends still point at the old snapshots) because that needs--replace-slug. Production boots the immutable ids in this manifest, so machines are unaffected, but the convenience pointers are now stale.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Rebakes the base and desktop devbox images from main so the Option+Backspace word-delete fix and preceding Dockerfile change reach machines; the old defaults were baked from a commit that never landed on main.
Migration
cmux-devbox-lgand friends) still point at the old snapshots and need a--replace-slugrun; production machines are unaffected because they boot the immutable image ids.Written for commit e02060a. Summary will update on new commits.
Summary by CodeRabbit