Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
ffb6d1d
test: reproduce Claude NODE_OPTIONS tmpdir purge
austinywang Sep 6, 2026
8440946
fix: keep Claude NODE_OPTIONS restore shim durable
austinywang Sep 6, 2026
6f41dfd
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang Sep 6, 2026
b079d3e
chore: normalize CLI source wiring
austinywang Sep 6, 2026
1d7a358
test: clean up Claude wrapper regression harness
austinywang Sep 6, 2026
d692992
fix: restore legacy Claude preload paths
austinywang Sep 6, 2026
5a06975
test: cover legacy Claude preload migration
austinywang Sep 6, 2026
e5ec22e
fix: preserve quoted Claude node options
austinywang Sep 6, 2026
41a82ff
fix: localize Claude node options error
austinywang Sep 6, 2026
989359a
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang Sep 6, 2026
a70322a
fix: place Claude error localization in catalog
austinywang Sep 6, 2026
a0bc896
fix: restore main build compatibility
austinywang Sep 6, 2026
1c7bdeb
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang Sep 6, 2026
b909c31
fix(cloud): restore catalog rename compatibility APIs
austinywang Sep 6, 2026
8635e54
fix: clear current main warning budget
austinywang Sep 6, 2026
5af2d06
fix: correct browser payload mutability
austinywang Sep 6, 2026
89959e7
Merge branch 'main' into issue-12022-wrapper-shim-tmpdir
austinywang Sep 6, 2026
b83b585
Merge branch 'main' into issue-12022-wrapper-shim-tmpdir
austinywang Sep 7, 2026
348021c
Merge branch 'main' into issue-12022-wrapper-shim-tmpdir
austinywang Sep 8, 2026
5017b6e
Merge branch 'main' into issue-12022-wrapper-shim-tmpdir
austinywang Sep 8, 2026
8e73509
Merge branch 'main' into issue-12022-wrapper-shim-tmpdir
austinywang Sep 8, 2026
1aaabcc
fix: wire local tmux helpers into app-host tests
austinywang Sep 8, 2026
9f204cc
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang Sep 8, 2026
6060750
fix: filter duplicate Claude restore preloads
austinywang Sep 8, 2026
1afa1ee
fix: remove duplicate cli definitions after main extraction
austinywang Sep 8, 2026
72f4796
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang Sep 8, 2026
6c50790
fix: restore semantic hook delivery after merge
austinywang Sep 8, 2026
2a1dc98
fix: expose shared CLI helpers across files
austinywang Sep 8, 2026
dde447a
fix: wire Claude node options into CLI target
austinywang Sep 8, 2026
9902ade
fix: remove duplicate Claude node option helpers
austinywang Sep 8, 2026
d0fe0f7
fix: wire cloud rename compatibility into app target
austinywang Sep 8, 2026
d4e26db
fix: preserve unset NODE_OPTIONS during legacy migration
austinywang Sep 8, 2026
250a4b2
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang Sep 8, 2026
12737f0
chore: remove obsolete Swift warning budget entries
austinywang Sep 8, 2026
eb47397
chore: normalize Xcode project wiring
austinywang Sep 8, 2026
91271ef
fix: restore semantic hook journal delivery
austinywang Sep 8, 2026
e236673
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang Sep 8, 2026
fa993cf
fix: preserve approval clears without request identity
austinywang Sep 8, 2026
40877a2
fix: harden Claude hook fallback paths
austinywang Sep 8, 2026
18e69b3
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang Sep 8, 2026
201268e
ci: rerun required checks after hosted runner flakes
austinywang Sep 9, 2026
58e39b8
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang Sep 9, 2026
fc9fc6e
ci: grandfather pre-existing determinism findings
austinywang Sep 9, 2026
a6fc232
ci: install Node for semantic integration tests
austinywang Sep 9, 2026
cfb4826
test: pass explicit Node path to Xcode harness
austinywang Sep 9, 2026
e177006
ci: forward Node path to Xcode test runner
austinywang Sep 9, 2026
0c36a75
test: keep OpenCode socket path short on macOS
austinywang Sep 9, 2026
6820f8f
ci: install Node for app-host tests
austinywang Sep 9, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/test-determinism-allowlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# Format: relpath<TAB>rule<TAB>short reason
# A finding whose (path, rule) appears here is suppressed.
# Remove a line once the underlying test is determinized.
Packages/Shared/CMUXMobileCore/Tests/CMUXMobileCoreTests/CmxRetryAfterPolicyTests.swift sleep-then-assert pre-existing on origin/main in #12179; injected policy sleep, remove when determinism checker recognizes it
Packages/iOS/CmuxMobileShell/Tests/CmuxMobileShellTests/MobileTerminalLaneCoordinatorTests.swift sleep-then-assert pre-existing on origin/main in #12007; remove when determinized
Packages/iOS/CmuxMobileRPC/Tests/CmuxMobileRPCTests/MobileCoreRPCTransportDrainTests.swift sleep-then-assert temporary outage debt owned by #8931; remove when determinized
Packages/iOS/CmuxMobileShellUI/Tests/CmuxMobileShellUITests/OnboardingMacDiscoveryKeepAliveTests.swift sleep-then-assert temporary outage debt owned by #9163; remove when determinized
cmuxTests/WorkspaceForkConversationContextMenuTests.swift assert-on-duration grandfathered
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,14 @@ jobs:
set -euo pipefail
./scripts/select-ci-xcode.sh

- name: Setup Node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: "20"

- name: Export Node path for Xcode test runner
run: echo "TEST_RUNNER_CMUX_NODE_BINARY=$(command -v node)" >> "$GITHUB_ENV"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node path dropped by console hop

Medium Severity

TEST_RUNNER_CMUX_NODE_BINARY is written to GITHUB_ENV so xcodebuild can forward CMUX_NODE_BINARY into the app-host tests, but every app-host invocation goes through run-in-console-session.sh, whose environment allowlist does not include that variable. The hop therefore drops it before xcodebuild runs, so OpenCodeHookRegressionTests still falls back to bare node on the isolated GUI PATH and cannot find the setup-node binary.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 6820f8f. Configure here.


- name: Capture Ghostty revision
id: ghostty-revision
run: |
Expand Down Expand Up @@ -1389,6 +1397,7 @@ jobs:
CMUX_CLI_BIN="$CLI_BIN" python3 tests/test_cli_socket_autodiscovery.py
python3 tests/test_codex_wrapper_resume_hooks.py
python3 tests/test_claude_wrapper_hooks.py
python3 tests/test_claude_wrapper_node_options_survives_tmpdir_purge.py
python3 tests/test_codex_wrapper_computer_use_mcp.py
python3 tests/test_cmux_cua_mcp_smoke.py
python3 tests/test_cmux_cua_build_cache_safety.py
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/test-depot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ jobs:
set -euo pipefail
./scripts/select-ci-xcode.sh

- name: Setup Node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: "20"

- name: Export Node path for Xcode test runner
run: echo "TEST_RUNNER_CMUX_NODE_BINARY=$(command -v node)" >> "$GITHUB_ENV"

- name: Setup Bun
uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2

Expand Down
Loading
Loading