Repository navigation
Keep Claude NODE_OPTIONS restore shim out of TMPDIR #12067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
ffb6d1d
test: reproduce Claude NODE_OPTIONS tmpdir purge
austinywang 8440946
fix: keep Claude NODE_OPTIONS restore shim durable
austinywang 6f41dfd
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang b079d3e
chore: normalize CLI source wiring
austinywang 1d7a358
test: clean up Claude wrapper regression harness
austinywang d692992
fix: restore legacy Claude preload paths
austinywang 5a06975
test: cover legacy Claude preload migration
austinywang e5ec22e
fix: preserve quoted Claude node options
austinywang 41a82ff
fix: localize Claude node options error
austinywang 989359a
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang a70322a
fix: place Claude error localization in catalog
austinywang a0bc896
fix: restore main build compatibility
austinywang 1c7bdeb
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang b909c31
fix(cloud): restore catalog rename compatibility APIs
austinywang 8635e54
fix: clear current main warning budget
austinywang 5af2d06
fix: correct browser payload mutability
austinywang 89959e7
Merge branch 'main' into issue-12022-wrapper-shim-tmpdir
austinywang b83b585
Merge branch 'main' into issue-12022-wrapper-shim-tmpdir
austinywang 348021c
Merge branch 'main' into issue-12022-wrapper-shim-tmpdir
austinywang 5017b6e
Merge branch 'main' into issue-12022-wrapper-shim-tmpdir
austinywang 8e73509
Merge branch 'main' into issue-12022-wrapper-shim-tmpdir
austinywang 1aaabcc
fix: wire local tmux helpers into app-host tests
austinywang 9f204cc
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang 6060750
fix: filter duplicate Claude restore preloads
austinywang 1afa1ee
fix: remove duplicate cli definitions after main extraction
austinywang 72f4796
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang 6c50790
fix: restore semantic hook delivery after merge
austinywang 2a1dc98
fix: expose shared CLI helpers across files
austinywang dde447a
fix: wire Claude node options into CLI target
austinywang 9902ade
fix: remove duplicate Claude node option helpers
austinywang d0fe0f7
fix: wire cloud rename compatibility into app target
austinywang d4e26db
fix: preserve unset NODE_OPTIONS during legacy migration
austinywang 250a4b2
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang 12737f0
chore: remove obsolete Swift warning budget entries
austinywang eb47397
chore: normalize Xcode project wiring
austinywang 91271ef
fix: restore semantic hook journal delivery
austinywang e236673
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang fa993cf
fix: preserve approval clears without request identity
austinywang 40877a2
fix: harden Claude hook fallback paths
austinywang 18e69b3
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang 201268e
ci: rerun required checks after hosted runner flakes
austinywang 58e39b8
Merge remote-tracking branch 'origin/main' into issue-12022-wrapper-s…
austinywang fc9fc6e
ci: grandfather pre-existing determinism findings
austinywang a6fc232
ci: install Node for semantic integration tests
austinywang cfb4826
test: pass explicit Node path to Xcode harness
austinywang e177006
ci: forward Node path to Xcode test runner
austinywang 0c36a75
test: keep OpenCode socket path short on macOS
austinywang 6820f8f
ci: install Node for app-host tests
austinywang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node path dropped by console hop
Medium Severity
TEST_RUNNER_CMUX_NODE_BINARYis written toGITHUB_ENVso xcodebuild can forwardCMUX_NODE_BINARYinto the app-host tests, but every app-host invocation goes throughrun-in-console-session.sh, whose environment allowlist does not include that variable. The hop therefore drops it before xcodebuild runs, soOpenCodeHookRegressionTestsstill falls back to barenodeon the isolated GUI PATH and cannot find the setup-node binary.Reviewed by Cursor Bugbot for commit 6820f8f. Configure here.