Fix iOS TestFlight archive type inference by azooz2003-bit · Pull Request #11998 · manaflow-ai/cmux

azooz2003-bit · 2026-09-05T03:00:56Z

Fix

The iOS TestFlight archive failed because the fallback return [] in the relay-cache Task inferred [Any], while the success path returned Set<String>. Return Set<String>() explicitly so both branches have the intended type.

Verification

git diff --check
Hosted iOS TestFlight archive verification pending
Previous failure: workflow run 33939121745

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

Summary by cubic

Fixes the iOS TestFlight archive failure where the relay-cache task's empty fallback inferred [Any] instead of Set<String>, and resolves the task via .value directly so both branches share the intended type without affecting relay-cache behavior.

^{Written for commit 24e5fe4. Summary will update on new commits.}

Summary by CodeRabbit

Refactor
- Improved internal handling of cached relay configuration and fallback processing.
- Preserved existing app behavior, with no changes to exported functionality or the user experience.

vercel · 2026-09-05T03:01:01Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
cmux166	Ready	Preview	Sep 5, 2026 5:49am UTC
cmux41	Ready	Preview	Sep 5, 2026 5:49am UTC

github-actions · 2026-09-05T03:01:17Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

coderabbitai · 2026-09-05T03:02:14Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 80f982fa-4b42-4994-ab06-71cbfc96637c

📥 Commits

Reviewing files that changed from the base of the PR and between 6bf8796 and 24e5fe4.

📒 Files selected for processing (1)

ios/cmuxPackage/Sources/cmuxFeature/MobileIrohRuntimeComposition.swift

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.

📝 Walkthrough

Walkthrough

The cached relay-policy fallback now returns an explicitly typed Set<String>. The cached relay URL task is awaited through its .value property.

Changes

Relay policy handling

Layer / File(s)	Summary
Typed cached relay fallback and task result handling `ios/cmuxPackage/Sources/cmuxFeature/MobileIrohRuntimeComposition.swift`	The cached relay-policy fallback returns `Set<String>`. Cached relay URL retrieval awaits the task’s `.value` result.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 24e5f

This change fixes iOS relay-cache type inference so fallback and successful relay results use the intended set type. No concrete current-head merge risk remains.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: fixing iOS TestFlight archive type inference.
Description check	✅ Passed	The description explains the cause and fix, and it lists verification performed and pending. It does not use the template headings and omits the checklist and review-trigger sections, but it provides …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Cmux Swift Actor Isolation	✅ Passed	PASS. The production diff changes only the relay-cache fallback type from `[]` to `Set<String>()` and awaits `cachedManagedRelayURLsTask.value`. It adds no actor, isolation, Sendable, protocol, model,…
Cmux Swift Blocking Runtime	✅ Passed	PASS: The commit changes only the relay-cache fallback from `return []` to `return Set<String>()` and awaits the existing task through `.value`. The diff adds no semaphore, blocking wait, sleep, delay…
Cmux Browser Automation Off-Main	✅ Passed	PASS. The pull request changes only `ios/cmuxPackage/Sources/cmuxFeature/MobileIrohRuntimeComposition.swift`. It changes relay-cache type inference and awaits `cachedManagedRelayURLsTask.value`. The d…
Cmux Expensive Synchronous Load	✅ Passed	The committed diff changes only the relay-cache fallback type from `[]` to `Set<String>()` and awaits the existing task with `.value`. It adds no agent-history loader, transcript/trajectory/JSONL pars…
Cmux Cache Substitution Correctness	✅ Passed	PASS: The diff changes only the fallback type from `[]` to `Set<String>()` and makes the existing task await explicit with `.value`. It does not replace a fresh authoritative read with a cache, and th…
Cmux No Hacky Sleeps	✅ Passed	PASS. The pull request changes only `ios/cmuxPackage/Sources/cmuxFeature/MobileIrohRuntimeComposition.swift`, which is Swift and outside this check's non-Swift scope. The two changes type the cache fa…
Cmux Algorithmic Complexity	✅ Passed	PASS. The diff changes only `MobileIrohRuntimeComposition.swift`: it types the fallback as `Set<String>()` and awaits `cachedManagedRelayURLsTask.value`. It introduces no loop, scan, sort, filter, joi…
Cmux Swift Concurrency	✅ Passed	PASS: The diff only changes the relay-cache fallback to `Set<String>()` and makes the existing await explicit with `.value`. It does not add or expand Dispatch queues, Combine state, completion-handle…
Cmux Swift `@Concurrent`	✅ Passed	PASS. The PR changes only the relay-cache task's fallback type and result access: `return Set<String>()` and `await cachedManagedRelayURLsTask.value`. It does not add or remove `@concurrent`, change `…
Cmux Swift Package Boundaries	✅ Passed	PASS. The diff changes only the existing relay-cache task in `MobileIrohRuntimeComposition.activate`: it replaces `return []` with `Set<String>()` and awaits `.value`. It does not introduce or materia…

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/ios-internal-build-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

8440039 Fix IROH reconnect churn and terminal typing stalls (manaflow-ai#11977) 4aa03bc Fix tab-less terminal close registry corruption (manaflow-ai#11991) 6993464 Fix nightly macOS build: repair what the manaflow-ai#11789 squash merge broke (manaflow-ai#11999) aac7a3e Merge pull request manaflow-ai#12001 from manaflow-ai/fix/ios-typing-latency f863155 fix(iOS): restore responsive terminal typing c27da77 Fix iOS terminal safe-area spacing when disconnected b8d9ee1 Merge pull request manaflow-ai#11998 from manaflow-ai/fix/ios-internal-build-type 24e5fe4 Fix iOS relay cache task type inference

Fix iOS relay cache task type inference

24e5fe4

azooz2003-bit force-pushed the fix/ios-internal-build-type branch from 6bf8796 to 24e5fe4 Compare September 5, 2026 03:06

azooz2003-bit merged commit b8d9ee1 into main Sep 5, 2026
17 of 21 checks passed

vercel Bot deployed to Preview – cmux41 September 5, 2026 05:48 View deployment

vercel Bot deployed to Preview – cmux166 September 5, 2026 05:49 View deployment

Navigation Menu

Uh oh!

Fix iOS TestFlight archive type inference - #11998

Fix iOS TestFlight archive type inference#11998
azooz2003-bit merged 1 commit into
mainfrom
fix/ios-internal-build-type

azooz2003-bit commented Sep 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Sep 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 5, 2026

Uh oh!

coderabbitai Bot commented Sep 5, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

azooz2003-bit commented Sep 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix

Verification

Summary by cubic

Summary by CodeRabbit

Uh oh!

vercel Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 5, 2026

Uh oh!

coderabbitai Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

azooz2003-bit commented Sep 5, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented Sep 5, 2026 •

edited

Loading

coderabbitai Bot commented Sep 5, 2026 •

edited

Loading