Keep Iroh enabled for the terminal client ABI - #11989
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe terminal client now enables the ChangesTerminal client transport
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The terminal client now retains Iroh transport support without changing normal cmux-tui builds. No merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fb1a73f to
5d11c7e
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
5d11c7e to
e135d54
Compare
fc6919b Fix terminal client Iroh feature after default change (manaflow-ai#11989) 3a368ff Publish VM ports with organization hostnames and scoped email grants (manaflow-ai#11986) f31c827 First-class Amp autoresume, notifications, and Vault support (manaflow-ai#9803) 19f51d5 Cloud VPN: app-managed WireGuard tunnel via a NetworkExtension system extension, on-demand only (manaflow-ai#11789) 866282e Fix Freestyle attach bundle readiness handling (manaflow-ai#11983) # Conflicts: # .github/workflows/ci.yml # .github/workflows/cloud-vm-image-contract.yml # .github/workflows/cmux-tui-artifacts.yml # .github/workflows/cmux-tui-build-package.yml # .github/workflows/nightly.yml # .github/workflows/release.yml # .github/workflows/reload-build.yml
Problem
The Iroh default feature is now disabled for the normal cmux-tui dependency graph. The separate
cmux-terminal-clientC ABI is still an Iroh-only client, but its manifest inherited that new default and no longer enabledcmux-remote'siroh-transportfeature. Workspace macOS clippy then failed with unresolved Iroh types.Change
Enable
cmux-remote/iroh-transportexplicitly forcmux-terminal-client. This keeps Iroh out of normalcmux-tuibuilds while preserving the existing C ABI client's transport.Validation
The release-path macOS arm64 build succeeded before this fix. Hosted verification will run clippy and the focused TUI test for this exact commit.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Enables the
iroh-transportfeature forcmux-terminal-clientso the C ABI client retains Iroh support after the default feature change.cmux-tuibuilds stay without Iroh; only the C ABI client enables the transport.Written for commit e135d54. Summary will update on new commits.
Summary by CodeRabbit