Skip to content

Keep Iroh enabled for the terminal client ABI - #11989

Merged
lawrencecchen merged 1 commit into
mainfrom
codex/build-main-tui-7ab687
Sep 5, 2026
Merged

lawrencecchen merged 1 commit into
mainfrom
codex/build-main-tui-7ab687

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The Iroh default feature is now disabled for the normal cmux-tui dependency graph. The separate cmux-terminal-client C ABI is still an Iroh-only client, but its manifest inherited that new default and no longer enabled cmux-remote's iroh-transport feature. Workspace macOS clippy then failed with unresolved Iroh types.

Change

Enable cmux-remote/iroh-transport explicitly for cmux-terminal-client. This keeps Iroh out of normal cmux-tui builds while preserving the existing C ABI client's transport.

Validation

The release-path macOS arm64 build succeeded before this fix. Hosted verification will run clippy and the focused TUI test for this exact commit.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Enables the iroh-transport feature for cmux-terminal-client so the C ABI client retains Iroh support after the default feature change.

  • The client previously inherited the disabled-by-default Iroh setting, breaking macOS clippy with unresolved Iroh types.
  • Normal cmux-tui builds stay without Iroh; only the C ABI client enables the transport.

Written for commit e135d54. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Chores
    • Updated remote connection transport support to improve connectivity compatibility.
    • This change does not alter the user interface or introduce new user-facing functionality.

@vercel

vercel Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cmux166 Ready Ready Preview Sep 5, 2026 4:51am UTC
cmux41 Ready Ready Preview Sep 5, 2026 4:51am UTC

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: c6343d8c-ef60-4575-9c79-a8c711b1b2cc

📥 Commits

Reviewing files that changed from the base of the PR and between f31c827 and 5d11c7e.

📒 Files selected for processing (1)
  • cmux-tui/crates/cmux-terminal-client/Cargo.toml

Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

The terminal client now enables the iroh-transport feature on its cmux-remote workspace dependency.

Changes

Terminal client transport

Layer / File(s) Summary
Transport feature wiring
cmux-tui/crates/cmux-terminal-client/Cargo.toml
The cmux-remote workspace dependency now enables the iroh-transport feature.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e135d

The terminal client now retains Iroh transport support without changing normal cmux-tui builds. No merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the problem, the change, and the validation. It does not use the template headings and omits the checklist, but the required technical context is present and the demo …
Title check ✅ Passed The title clearly identifies the main change: retaining Iroh support for the terminal client ABI by keeping Iroh enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Cmux Swift Actor Isolation ✅ Passed PASS. The pull request changes only cmux-tui/crates/cmux-terminal-client/Cargo.toml; the exact commit diff contains one Rust dependency feature change and no Swift files or Swift declarations. There…
Cmux Swift Blocking Runtime ✅ Passed PASS. The commit changes only cmux-tui/crates/cmux-terminal-client/Cargo.toml: it enables the iroh-transport feature on cmux-remote. The diff contains no Swift files and no blocking or timing pr…
Cmux Browser Automation Off-Main ✅ Passed PASS. The pull request changes only cmux-tui/crates/cmux-terminal-client/Cargo.toml, adding the iroh-transport feature to cmux-remote. The diff changes no browser command, WebKit/AppKit access, …
Cmux Expensive Synchronous Load ✅ Passed PASS. The pull request changes only cmux-tui/crates/cmux-terminal-client/Cargo.toml. It adds the iroh-transport Cargo feature to cmux-remote. The diff contains no Swift files and no agent-histor…
Cmux Cache Substitution Correctness ✅ Passed The pull request changes only cmux-tui/crates/cmux-terminal-client/Cargo.toml. It enables the Rust cmux-remote iroh-transport feature. The commit contains no Swift, TypeScript, or JavaScript cha…
Cmux No Hacky Sleeps ✅ Passed PASS. The pull request changes only cmux-tui/crates/cmux-terminal-client/Cargo.toml. It adds the iroh-transport Cargo feature to cmux-remote. No TypeScript, JavaScript, shell, or runtime-script …
Cmux Algorithmic Complexity ✅ Passed PASS. The PR changes only cmux-tui/crates/cmux-terminal-client/Cargo.toml, a Rust dependency declaration. It adds the iroh-transport feature to cmux-remote; it does not add or modify production …
Cmux Swift Concurrency ✅ Passed PASS: The pull request changes only cmux-tui/crates/cmux-terminal-client/Cargo.toml. The diff changes one Rust dependency declaration and contains no Swift files or Swift concurrency patterns. There…
Cmux Swift @Concurrent ✅ Passed PASS: The pull request changes only cmux-tui/crates/cmux-terminal-client/Cargo.toml. The exact diff adds the Rust cmux-remote feature iroh-transport; it changes no Swift files, Swift isolation, …
Cmux Swift Package Boundaries ✅ Passed The pull request changes only cmux-tui/crates/cmux-terminal-client/Cargo.toml. The diff contains no Swift files or Swift production code. Therefore, the Swift package-boundary failure conditions do …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/build-main-tui-7ab687

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen
lawrencecchen force-pushed the codex/build-main-tui-7ab687 branch from fb1a73f to 5d11c7e Compare September 5, 2026 01:38
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@lawrencecchen
lawrencecchen force-pushed the codex/build-main-tui-7ab687 branch from 5d11c7e to e135d54 Compare September 5, 2026 01:48
@lawrencecchen
lawrencecchen merged commit fc6919b into main Sep 5, 2026
33 of 36 checks passed
@lawrencecchen
lawrencecchen deleted the codex/build-main-tui-7ab687 branch September 5, 2026 01:59
rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 5, 2026
fc6919b Fix terminal client Iroh feature after default change (manaflow-ai#11989)
3a368ff Publish VM ports with organization hostnames and scoped email grants (manaflow-ai#11986)
f31c827 First-class Amp autoresume, notifications, and Vault support (manaflow-ai#9803)
19f51d5 Cloud VPN: app-managed WireGuard tunnel via a NetworkExtension system extension, on-demand only (manaflow-ai#11789)
866282e Fix Freestyle attach bundle readiness handling (manaflow-ai#11983)

# Conflicts:
#	.github/workflows/ci.yml
#	.github/workflows/cloud-vm-image-contract.yml
#	.github/workflows/cmux-tui-artifacts.yml
#	.github/workflows/cmux-tui-build-package.yml
#	.github/workflows/nightly.yml
#	.github/workflows/release.yml
#	.github/workflows/reload-build.yml
aerickson pushed a commit to aerickson/cmux that referenced this pull request Sep 13, 2026

This branch was successfully deployed

2 active deployments
Preview – cmux41 — e135d544 Deployed Sep 5, 2026 by vercel[bot]
Preview – cmux166 — e135d544 Deployed Sep 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant