fix(cmux-tui): clear two current clippy lints - #11853
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Error::otherin the crossterm poll-error testOpenOptionsin the bounded HTTP-token growth testThese are mechanical lint-only changes. Existing tests already cover both behavior paths, so no new source-shape test is needed.
Base:
33b34b22b732e89716a511bec56d3886740c486bHead:
2ac2eb21a05Workspace Clippy, rustfmt, and tests will run on Blacksmith after the Actions rate limit resets.
Summary by cubic
Updates two tests to clear current Clippy lints without changing production behavior.
std::io::Error::otherwhen constructing the poll error.OpenOptionstype in the HTTP-token growth test.Written for commit 2ac2eb2. Summary will update on new commits.