Skip to content

fix(cmux-tui): clear two current clippy lints - #11853

Merged
lawrencecchen merged 2 commits into
mainfrom
fix/cmux-tui-clippy-baseline-current
Sep 3, 2026
Merged

lawrencecchen merged 2 commits into
mainfrom
fix/cmux-tui-clippy-baseline-current

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • use Error::other in the crossterm poll-error test
  • use the imported OpenOptions in the bounded HTTP-token growth test

These are mechanical lint-only changes. Existing tests already cover both behavior paths, so no new source-shape test is needed.

Base: 33b34b22b732e89716a511bec56d3886740c486b
Head: 2ac2eb21a05

Workspace Clippy, rustfmt, and tests will run on Blacksmith after the Actions rate limit resets.


Summary by cubic

Updates two tests to clear current Clippy lints without changing production behavior.

  • Uses std::io::Error::other when constructing the poll error.
  • Uses the imported OpenOptions type in the HTTP-token growth test.

Written for commit 2ac2eb2. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cmux166 Building Building Preview Sep 3, 2026 1:17pm UTC
cmux41 Building Building Preview Sep 3, 2026 1:17pm UTC

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 283e5a64-51f8-42bf-8b1f-1c321fac829f

📥 Commits

Reviewing files that changed from the base of the PR and between 33b34b2 and 2ac2eb2.

📒 Files selected for processing (2)
  • cmux-tui/crates/cmux-remote/src/http.rs
  • cmux-tui/crates/cmux-tui/src/app.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@lawrencecchen
lawrencecchen merged commit c4f600d into main Sep 3, 2026
45 of 47 checks passed

This branch was successfully deployed

2 active deployments
Preview – cmux166 — 2ac2eb21 Deployed Sep 3, 2026 by vercel[bot]
Preview – cmux41 — 2ac2eb21 Deployed Sep 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant