Repository navigation
Fix tab scroll range fitting complexity - #11684
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
lawrencecchen
force-pushed
the
feat-tui-tab-scroll-range-fit
branch
3 times, most recently
from
September 2, 2026 15:19
92b2782 to
28daa6b
Compare
lawrencecchen
force-pushed
the
feat-tui-tab-scroll-range-fit
branch
from
September 2, 2026 15:24
28daa6b to
e40f6ca
Compare
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 2, 2026
436fc1f Add unified surface selection context API (manaflow-ai#10022) d028302 Merge pull request manaflow-ai#11696 from manaflow-ai/audit-tui-graphics-diff-wave202 11af2f2 perf(cmux-tui): index graphics pointer routes 60d06c2 Merge pull request manaflow-ai#11687 from manaflow-ai/feat-config-key-dispatch-complexity 0358c30 Merge pull request manaflow-ai#11684 from manaflow-ai/feat-tui-tab-scroll-range-fit 2c0c8a4 test(cmux-tui): bound graphics diff comparisons 8187531 Merge pull request manaflow-ai#11672 from manaflow-ai/issue-remote-tree-cache-race f0ff9cf Merge pull request manaflow-ai#11630 from manaflow-ai/feat-journal-group-commit f1e2d3f perf(tui): cache key dispatch maps 96897a7 test(tui): cover cached key dispatch refresh e40f6ca fix tab scroll range fitting complexity 275cf7c test tab scroll range fitting at scale 995638d Merge pull request manaflow-ai#11640 from manaflow-ai/feat-tui-worker-cancellation 790b53f perf(tui): avoid pane area frame clone (manaflow-ai#11404) 6a5dd4d fix(tui): reap PTY child on startup failure (manaflow-ai#11414) 2ebb5a5 fix(tui): clear stale agent updates at snapshot boundary 3b91c0c test(tui): prevent stale agent resurrection after omission 789b350 fix(tui): retain agent updates across topology races 85cbff1 test(tui): retain agent updates across topology omission 586a2a6 perf(cmux-tui): resolve resource selectors without the registry lock 7fb5414 fix(cmux-tui): cancel blocked machine worker sends dd7347e test(cmux-tui): cover cancellable machine completion send
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The renderer keeps Ratatui's standard model: compute bounded Rects and write widgets into the frame buffer. See https://docs.rs/ratatui/latest/ratatui/struct.Frame.html and https://docs.rs/ratatui/latest/ratatui/layout/struct.Rect.html.
Verification
Two commits are intentional: the first adds the failing behavior tests, the second adds the fix.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes tab scroll range fitting so large tab sets no longer cause quadratic work. Replaces repeated range scans with a one-pass accumulated width subtraction and adds tests for preserving requested offsets and fitting active tabs at scale.
Written for commit e40f6ca. Summary will update on new commits.