Skip to content

cloud: fix typecheck in the devbox size scripts #11678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 1 commit into from
Sep 2, 2026
Merged

cloud: fix typecheck in the devbox size scripts #11678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/scripts/derive-devbox-sizes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* the master already has that shape, so it is recorded without a second
* snapshot.
*/
import { Freestyle } from "freestyle";
import { Freestyle, type FirewallSpec } from "freestyle";
import { writeFileSync } from "node:fs";
import {
VM_IMAGE_SIZE_NAMES,
Expand Down Expand Up @@ -55,7 +55,7 @@ for (const name of requested) {
const sizes = requested as VmImageSizeName[];
const replaceSlug = hasFlag("--replace-slug");

const FIREWALL = { rules: [{ action: "allow" as const, source: {}, destination: { public: true } }] };
const FIREWALL: FirewallSpec = { rules: [{ action: "allow", source: {}, destination: { public: true } }] };
const sleep = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));

type Exec = { exec: (options: { command: string; timeoutMs?: number; linuxUser?: string }) => Promise<{ stdout?: string | null; stderr?: string | null; statusCode?: number | null }> };
Expand Down
2 changes: 1 addition & 1 deletion web/scripts/devbox-image-common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ export function promoteImageManifestEntry(
}
}
}
const promotedSizes = new Set(variants.map((variant) => variant.size?.name ?? ""));
const promotedSizes = new Set<string>(variants.map((variant) => variant.size?.name ?? ""));
const demoted = manifest.images.map((candidate) => {
if (candidate.provider !== entry.provider) return candidate;
const next: DevboxManifestEntry = { ...candidate };
Expand Down