Repository navigation
Add Copy to notification context menus - #11677
Merged
Merged
Conversation
Right-clicking a notification in the titlebar popover or the Notifications pane now offers Copy, which writes the workspace title, notification title, and detail line as plain text. Both surfaces go through one TerminalNotificationClipboard path.
|
Warning Review limit reachedNext included review available in 10 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 2, 2026
5db1af3 Merge pull request manaflow-ai#11589 from manaflow-ai/feat-replay-tombstone c98bf28 Check manifest size problems without the arrayContaining shim (manaflow-ai#11681) dab9d7f fix(remote): retain all lanes on remote reset 873f9a3 test(remote): cover reset tombstone data lanes 9598aad fix(remote): retain handshake lane on pending open teardown 72ab166 test(remote): cover pending open handshake tombstone ecf12d7 fix(remote): retain legal lanes for rejected opens 156fb23 test(remote): cover open-limit data lane tombstone 096119e test(remote): assert lane-specific tombstone retention 0e0bb62 fix(remote): scope tombstones to the closed lane e152bb4 test(remote): cover cross-lane close tombstone retention 62f8e4d test(remote): churn tunnel tombstones to configured bound edd0b97 fix(remote): retain tunnel tombstones through replay window 84640ad test(remote): expose tunnel tombstone churn 1ba8941 fix(remote): retain legal lanes on removal 28599ae test(remote): retain removal tombstones across legal lanes 09bffdc fix(remote): retain all legal lanes on drop bf73e72 test(remote): retain dropped stream legal lane tombstone e09b07c fix(remote): retain dropped stream lane tombstones 3c282a2 test(remote): retain dropped stream tombstone lane 0f6e222 fix(remote): match tombstones by lane 0eea0c1 test(remote): reject wrong-lane tombstone frames 051e9ca fix(remote): remove obsolete tombstone helper 5bddc99 fix(remote): scope tombstones to affected lanes eac37bc fix(remote): retain tombstones per replay lane 8480e7b test(remote): expose replay tombstone churn e341deb Fix main CI: guard exemption, manifest typecheck, docs-channel Vercel config, device registry test isolation (manaflow-ai#11648) 3425245 web: bake the cmux-tui daemon into the Freestyle devbox; create is vms.create plus one file write (manaflow-ai#11666) e941f22 Add Copy to notification context menus (manaflow-ai#11677) 792b9cb cmux-tui: fix clippy 1.95 lints so the full gate is green again (manaflow-ai#11625) 8711a34 cloud: fix typecheck in the devbox size scripts (manaflow-ai#11678)
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right-clicking a notification row in the titlebar bell popover or in the Notifications pane now shows a Copy item. It writes the workspace title, the notification title, and the detail line (body, falling back to subtitle like the sidebar and menu bar already do) to the pasteboard as plain text.
Both surfaces call one shared
TerminalNotificationClipboard.copypath; the text formatting lives onTerminalNotification.clipboardText(workspaceTitle:). The Notifications pane row had no context menu before, so it also gains Open and Dismiss to match the popover.Localization:
notifications.copyadded in en and ja, matching the othernotifications.*keys.Tests:
TerminalNotificationClipboardTestscovers text formatting (workspace title, empty detail, subtitle fallback, duplicate title) and the pasteboard write against a private named pasteboard.Summary by cubic
Adds Copy to the notification context menus in the titlebar bell popover and the Notifications pane. Right-clicking a notification now writes the workspace title, notification title, and detail line to the pasteboard as plain text; the Notifications pane row previously had no context menu, so it also gains Open and Dismiss to match the popover.
The copied detail uses
bodywith a fallback tosubtitleand drops detail that repeats the title. Both surfaces share oneTerminalNotificationClipboard.copypath, andnotifications.copyis localized in en and ja. Tests cover the formatting rules and a pasteboard write.Written for commit 7771c2d. Summary will update on new commits.