Repository navigation
ci: pin CLA Assistant to the whitespace fix and admit comments by substring - #11598
Merged
Merged
Conversation
…string GitHub appends CRLF to plain comments, so an equality test on the comment body dropped both signing declarations and recheck requests. manaflow-ai/cla-github-action#15 trims the declaration; the workflow now admits comments by substring and lets the action do the exact match. Claude-Session: https://claude.ai/code/session_019AS5qLDrLFuaJo6zxaZbCk
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Closed
1 task
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub appends CRLF to plain comments, so the equality test on the comment body dropped both signing declarations and recheck requests (theswerd's declaration on #11590 was never recorded). manaflow-ai/cla-github-action#15 trims the declaration before its exact match; the workflow now admits comments by substring and lets the action do the exact match.
https://claude.ai/code/session_019AS5qLDrLFuaJo6zxaZbCk
Summary by cubic
Fixes the CLA Assistant workflow so signing declarations and recheck requests are no longer dropped when GitHub appends CRLF to plain comments.
The workflow previously matched the comment body exactly; it now admits comments by substring and pins the CLA Assistant action to a version that trims whitespace before its exact match.
Written for commit 9807eec. Summary will update on new commits.