Repository navigation
docs(tui): align protocol contracts with runtime - #11403
lawrencecchen wants to merge 3 commits into
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe specification updates document stricter incomplete-size handling, verified ChangesProtocol specification
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change updates TUI protocol documentation and inventory without changing runtime behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Description checkExplanation The description includes a clear summary, testing details, and scope that match the pull request objectives. The demo video is not needed for this documentation-only change. The review trigger and checklist sections are omitted, but the description is otherwise mostly complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.) Full details: Cmux Swift Actor IsolationExplanation PASS: The complete PR range from 717f357 to b02f174 changes only four cmux-tui specification files. The diff contains no Swift paths and no production code changes, so it cannot introduce or worsen Swift actor-isolation mistakes. Full details: Cmux Swift Blocking RuntimeExplanation PASS: The pull request diff from its documented base ( Full details: Cmux Browser Automation Off-MainExplanation PASS: The pull request changes only four files under Full details: Cmux Expensive Synchronous LoadExplanation PASS: The pull request changes only four documentation/specification files: Full details: Cmux Cache Substitution CorrectnessExplanation PASS: The pull-request range from base 717f357 to HEAD changes only Full details: Cmux No Hacky SleepsExplanation PASS: The pull request diff from its base contains only four documentation/inventory files: Full details: Cmux Algorithmic ComplexityExplanation PASS: The pull request changes only four documentation/specification files: three Markdown files and one JSON inventory file. The verified diff contains no Swift, TypeScript, JavaScript, shell, or runtime code, so it cannot introduce the algorithmic-complexity failures defined by this check. Full details: Cmux Swift ConcurrencyExplanation PASS: The cumulative PR diff from 717f357 changes only four documentation/spec files: cmux-tui/spec/commands.md, events.md, inventory.json, and programmability.md. It contains no Swift paths or Swift concurrency changes. Therefore, it does not introduce or expand any prohibited legacy async pattern. Full details: Cmux Swift `@Concurrent`Explanation PASS: The pull-request diff from Full details: Cmux Swift Package BoundariesExplanation PASS: The pull request diff contains only four documentation/specification files: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 4 files
You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
|
Superseded by #11418, which contains the same documentation contract changes plus follow-up corrections and is based on current main. |
This branch was successfully deployed
1 participant
Summary
Testing
git diff --checkpython3 cmux-tui/scripts/check-spec-inventory.pypython3 -m unittest cmux-tui/scripts/test_check_spec_inventory.pyScope
Summary by cubic
Updates the TUI protocol docs and inventory so they match the runtime implementation. No runtime code changes.
Scope
move-tabclamping, no-op, and cross-pane behavior in the command contract.terminal-hostinventory as v4 implemented, with v1-v3 negotiation still supported.client-attachedandclient-detachedevents for legacy and resource attachment streams.Written for commit b02f174. Summary will update on new commits.
Summary by CodeRabbit
move-tabbehavior for clamped indexes, no-op moves, and pane cleanup.