Repository navigation
fix(cmux-tui): fence repeated ABA echo keys - #11377
lawrencecchen wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as superseded by current main (6d67bc5). The PR relies on the old agent-report-echo-v4 transition-key path in mux.rs. Current main replaced that path with durable resource mutation revisions and hook-fence checks, so the ABA hunk has no target context after refresh. Current main also carries lifecycle-fence coverage for delayed old session starts and late events. Reapplying these three commits onto current main cannot produce a safe, narrow patch. |
Stacked follow-up for PR #11002.
The durable echo key previously hashed only the current semantic state and its predecessor. A repeated Working → Blocked → Working → Blocked cycle reused the earlier Blocked key and could replay or reject the later transition.
This adds a durable monotonic resource revision to the transition key. Immediate identical reports still coalesce before key generation.
Commits:
Validation:
git diff --check; hosted cmux-tui verification is required because local Cargo/rustc is prohibited.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes repeated ABA echo key reuse in
cmux-tuiby including a durable monotonic resource revision in the transition key, so repeated Working → Blocked → Working cycles no longer reuse an earlier key and can replay or reject the later transition.Written for commit 3a62c0e. Summary will update on new commits.