Repository navigation
cloud-vm smoke: --paid marks the smoke user as a pro plan - #11375
Merged
Merged
Conversation
The Pro gate (#11332) returns 402 vm_requires_pro for free plans, which killed the sanctioned production create smoke. --paid sets the billing metadata key the entitlements layer reads (clientReadOnlyMetadata cmuxVmPlan=pro) on the throwaway smoke user, restoring the verification path without touching the global CMUX_VM_ALLOW_FREE_PROVISIONING escape hatch. Verified against production: paid create 200 on blaxel, attach, destroy clean; unpaid still 402.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pro gate (#11332) returns 402
vm_requires_profor free plans, which killed the sanctioned production create smoke (scripts/cloud-vm/smoke-vm-api.mjs --create).--paidsets the billing metadata key the entitlements layer reads (clientReadOnlyMetadata.cmuxVmPlan = "pro") on the throwaway smoke user, restoring the verification path without touching the globalCMUX_VM_ALLOW_FREE_PROVISIONINGescape hatch.Verified against production this morning while investigating the 07:10-07:29 UTC failure burst (Blaxel us-was-1 platform incident):
--paidcreate 200 on blaxel (34.8s during their degradation), attach over cmux-remote, destroy clean; without--paidthe same flow correctly 402s. Operator script only.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds a
--paidflag toweb/scripts/cloud-vm/smoke-vm-api.mjsthat sets thecmuxVmPlan = "pro"billing metadata key on the throwaway smoke user, restoring the create smoke path that broke when free plans started returning 402vm_requires_pro.--paid, the create flow still 402s as expected.CMUX_VM_ALLOW_FREE_PROVISIONINGescape hatch.Written for commit d5066c3. Summary will update on new commits.
Summary by CodeRabbit
--paidoption to the VM API smoke test, allowing tests to run with a simulated Pro plan.