Skip to content

Fix dashboard tab loading flashes - #11363

Merged
lawrencecchen merged 3 commits into
mainfrom
feat-dashboard-instant-navigation
Sep 1, 2026
Merged

lawrencecchen merged 3 commits into
mainfrom
feat-dashboard-instant-navigation

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade Next.js, @next/playwright, and eslint-config-next from 16.3.0 to the latest stable 16.3.4.
  • Keep the shared dashboard shell and current page mounted while CodeRouter and TestFlight resolve fresh account data.
  • Remove their full-page route loading boundaries and explicitly allow these request-fresh pages to block with instant = false.
  • Add a behavior test that prevents the dashboard layout from reintroducing a nested full-page fallback.

Verification

  • bun install --frozen-lockfile
  • bun run typecheck
  • Focused Bun tests: 7 passed
  • Focused ESLint
  • Existing instant-navigation Playwright test: 1 passed
  • Clean-install production bun run build: passed

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes dashboard tab navigation so switching between CodeRouter and TestFlight no longer flashes the full-page skeleton.

Bug Fixes

  • Keeps the shared dashboard shell and current page mounted while fresh page data resolves.
  • Opts CodeRouter and TestFlight out of instant navigation since their data must stay request-fresh.
  • Removes the per-page loading boundaries that rendered the nested fallback.
  • Adds a behavior test that prevents reintroducing the nested full-page fallback.

Dependencies

  • Upgrades next, @next/playwright, and eslint-config-next from 16.3.0 to 16.3.4.

Written for commit bb134f4. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cmux166 Building Building Preview Sep 1, 2026 7:26am UTC
cmux41 Building Building Preview Sep 1, 2026 7:26am UTC

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 0f2d7386-9471-4fd8-8b18-c968f9d01b8c

📥 Commits

Reviewing files that changed from the base of the PR and between d2a1ac9 and bb134f4.

⛔ Files ignored due to path filters (1)
  • web/bun.lock is excluded by !**/*.lock
📒 Files selected for processing (7)
  • web/app/[locale]/dashboard/coderouter/loading.tsx
  • web/app/[locale]/dashboard/coderouter/page.tsx
  • web/app/[locale]/dashboard/layout.tsx
  • web/app/[locale]/dashboard/testflight/loading.tsx
  • web/app/[locale]/dashboard/testflight/page.tsx
  • web/package.json
  • web/tests/dashboard-layout.test.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​next@​16.3.0 ⏵ 16.3.46110090 +19970
Updatednpm/​eslint-config-next@​16.3.0 ⏵ 16.3.4991006798100
Updatednpm/​@​next/​playwright@​16.3.0 ⏵ 16.3.4100 +2810010097100

View full report

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Re-trigger cubic

@lawrencecchen
lawrencecchen merged commit 71d7498 into main Sep 1, 2026
10 of 12 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 1, 2026

This branch was successfully deployed

2 active deployments
Preview – cmux41 — bb134f4b Deployed Sep 1, 2026 by vercel[bot]
Preview – cmux166 — bb134f4b Deployed Sep 1, 2026 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant