Skip to content

Bound daemon loss classification probes - #11151

Merged
lawrencecchen merged 6 commits into
feat-cloud-tui-manual-iofrom
fix/daemon-probe-timeout-wave104
Aug 28, 2026
Merged

lawrencecchen merged 6 commits into
feat-cloud-tui-manual-iofrom
fix/daemon-probe-timeout-wave104

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #11062.

Adds a fixed request deadline to both existing-tree and fallback reconnect probes, so synchronous request waits are bounded and pending requests are removed on timeout.

Tokio reference: https://docs.rs/tokio/latest/tokio/time/fn.timeout.html


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Bounds daemon loss classification probes so reconnect checks no longer hang when a daemon stops responding. Previously the existing-tree refresh and fallback reconnect probe could block indefinitely on the refresh lock, connection, or synchronous requests; now both share a single 500ms deadline across connect, transport setup, initialization, and tree refresh, with pending requests dropped on timeout.

Written for commit befc239. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux166 Ready Ready Preview Aug 28, 2026 11:17pm
cmux41 Ready Ready Preview Aug 28, 2026 11:17pm

@coderabbitai

coderabbitai Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0bea1176-a658-46ad-8d4b-523061aaf04a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen
lawrencecchen merged commit f85b196 into feat-cloud-tui-manual-io Aug 28, 2026
56 of 64 checks passed

This branch was successfully deployed

2 active deployments
Preview – cmux41 — befc2392 Deployed Aug 28, 2026 by vercel[bot]
Preview – cmux166 — befc2392 Deployed Aug 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant