Bound daemon loss classification probes - #11151
Merged
lawrencecchen merged 6 commits intoAug 28, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lawrencecchen
merged commit Aug 28, 2026
f85b196
into
feat-cloud-tui-manual-io
56 of 64 checks passed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11062.
Adds a fixed request deadline to both existing-tree and fallback reconnect probes, so synchronous request waits are bounded and pending requests are removed on timeout.
Tokio reference: https://docs.rs/tokio/latest/tokio/time/fn.timeout.html
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Bounds daemon loss classification probes so reconnect checks no longer hang when a daemon stops responding. Previously the existing-tree refresh and fallback reconnect probe could block indefinitely on the refresh lock, connection, or synchronous requests; now both share a single 500ms deadline across connect, transport setup, initialization, and tree refresh, with pending requests dropped on timeout.
Written for commit befc239. Summary will update on new commits.