Skip to content

fix(tui): preserve preview when sidebar target is stale - #11149

Open
lawrencecchen wants to merge 38 commits into
task-10946-sidebar-preview-integrationfrom
fix-pr11101-stale-target-wave103
Open

lawrencecchen wants to merge 38 commits into
task-10946-sidebar-preview-integrationfrom
fix-pr11101-stale-target-wave103

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up for #11101.

Validate the target surface before committing workspace preview state. A closed or replaced target now leaves the existing preview and selection unchanged. Includes a regression test. Exact hosted gate and canonical autoreview are pending.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Validates the complete sidebar target (workspace, screen, pane, and tab index) before committing a workspace preview, so a stale click on a closed, replaced, or moved tab is now a no-op instead of selecting a different surface. Extends this guard to rendered tab hits and includes regression tests.

Written for commit e9a1755. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux166 Ready Ready Preview Aug 28, 2026 11:56pm
cmux41 Ready Ready Preview Aug 28, 2026 11:56pm

@greptile-apps

greptile-apps Bot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Too many files changed for review (238 files, 100 file limit).

Bypass the limit by tagging @greptile-apps to review.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4ad1de13-9c1d-4f86-af58-b8c829accbb5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Aug 28, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@lawrencecchen
lawrencecchen force-pushed the task-10946-sidebar-preview-integration branch from 815dbf5 to 1eed2fa Compare August 30, 2026 04:48
@teamleaderleo teamleaderleo added area: terminal Ghostty surface, rendering, scrollback, escape sequences, fonts area: workspaces Workspaces, sessions, restore after relaunch, worktrees S2: major A crash, hang, lost state, broken connection, or a regression on a path people use ready-to-land Reviewed and ready to land when CI is green labels Sep 30, 2026

This branch was successfully deployed

2 active deployments
Preview – cmux41 — e9a1755b Deployed Aug 28, 2026 by vercel[bot]
Preview – cmux166 — e9a1755b Deployed Aug 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: terminal Ghostty surface, rendering, scrollback, escape sequences, fonts area: workspaces Workspaces, sessions, restore after relaunch, worktrees ready-to-land Reviewed and ready to land when CI is green S2: major A crash, hang, lost state, broken connection, or a regression on a path people use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants