Repository navigation
Fix plugin operation lock API - #11132
lawrencecchen wants to merge 18 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fc50539 to
3fc686d
Compare
|
The plugin-manager path this fix targeted was replaced by #13299, which is on main, so this PR is superseded. Closing it. |
Use fs4's supported
lock_exclusiveAPI so the operation lock compiles and remains exclusive.Follow-up to #10992.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes the plugin operation lock so it uses
fs4's lock API supported by the MSRV and remains exclusive. Also makes plugin installs crash-safe: they now run as journaled transactions with rollback and recovery, and error responses no longer leak internal details.Details
install,use,update, andremoveacquire the lock;listand read-only paths skip it and reject reads when a recovery journal is pending.Written for commit e495836. Summary will update on new commits.