Skip to content

chatmux-relay: reject empty option values #11113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 3 commits into from
Aug 28, 2026
Merged

chatmux-relay: reject empty option values #11113

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a168138
test(chatmux-relay): reject empty option values
lawrencecchen Aug 28, 2026
73f3fdc
fix(chatmux-relay): reject empty option values
lawrencecchen Aug 28, 2026
ba9a558
style(chatmux-relay): format CLI parser
lawrencecchen Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmux-tui/crates/chatmux-relay/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ where

if is_value_flag(argument) {
let value = args.get(index + 1).map(String::as_str);
let usable = value.is_some_and(|value| value != "--" && !value.starts_with('-'));
let usable = value
.is_some_and(|value| !value.is_empty() && value != "--" && !value.starts_with('-'));
if !usable {
return Err(missing_value(argument));
}
Expand Down Expand Up @@ -234,6 +235,7 @@ mod tests {
&["--backend", "--code"][..],
&["--backend", "--"][..],
&["--allow-root", "--status"][..],
&["--config", ""][..],
] {
let error = parse(args).expect_err("missing value refused");
assert!(error.message.contains("requires a value"), "{args:?}: {}", error.message);
Expand Down
Loading