Skip to content

fix(tui): preserve workspace preview across child rails - #10946

Closed
lawrencecchen wants to merge 6 commits into
feat-tui-sidebar-previewfrom
review/tui-sidebar-pr10736-wave53
Closed

lawrencecchen wants to merge 6 commits into
feat-tui-sidebar-previewfrom
review/tui-sidebar-pr10736-wave53

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Keep a workspace preview active while focus moves from the workspace rail into the tabs or projection (agents) rail. Those child rails now continue to show the highlighted workspace. Moving to the machine rail or pane still cancels the preview.

Testing

  • rustfmt --edition 2024 --check cmux-tui/crates/cmux-tui/src/app.rs
  • git diff --check
  • Hosted focused Linux and macOS verification: pending
  • Regression test: workspace_preview_survives_workspace_dependent_rail_navigation

Review Trigger

Stacked on #10736.


Summary by cubic

Keeps the workspace preview active as focus moves between the workspace, tabs, and projection rails, so those child views keep following the highlighted workspace. Activating a tabs rail target now commits the preview; moving to the machine rail or pane still cancels it and restores the original active workspace.

  • Adds regression tests for previews preserved across child rails, hover previews committed on row click, and previews committed when a tabs rail target is activated.

Written for commit e062c7f. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3631c3ef-8605-4b9e-8606-a2ba5eee854b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Superseded by PR #10969, which includes this child-rail persistence work in the unified preview stack. Closing this intermediate stack member to avoid duplicate app.rs merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant