Repository navigation
ios: add minimal launch screen - #10621
Conversation
Declare UIColorName + UIImageName in the UILaunchScreen dict so cold launch shows the cmux mark centered on a systemBackground-matching adaptive color instead of a bare blank screen. Assets: LaunchBackground colorset (white/black) and LaunchLogo imageset (36x48pt mark at 1x/2x/3x, cut from the existing CmuxLogo art). Static, no text, per the HIG Launching guidance. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe iOS launch screen now references an adaptive light/dark background color and a logo image set. The asset catalog includes metadata for the background and universal 1x, 2x, and 3x logo assets. ChangesiOS launch screen
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The PR adds a static branded launch screen with adaptive background colors and introduces no user-facing text or localization changes; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR replaces the empty iOS launch-screen declaration with a centered cmux mark on an appearance-aware background.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "ios: match launch logo gradient to the s..." | Re-trigger Greptile |
The first LaunchLogo render was cropped from the app-bundled CmuxLogo raster, whose gradient runs far more purple than the brand mark on cmux.com. Re-render the launch PNGs from the chevron path and gradient stops in web/public/cmux-icon.svg (#12c7f5 -> #2d8cff -> #6c5cff), transparent background, same 34x48pt footprint. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Aziz flagged the mark still wasn't the one on cmux.com. Pixel-sampling shows THREE gradient variants in the wild: the site header logo.png and brand/app-icon-*.png agree (#5dcbfa -> #4f98f2 -> #586deb), while cmux-icon.svg runs more violet (#12c7f5 -> #2d8cff -> #6c5cff) and the iOS AppIcon raster is more purple still. The site is the reference, so the launch mark now uses the gradient fitted from the 1024px brand icon (3-stop horizontal fit, max sample error ~2/255 per channel). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Cold launch previously showed a bare blank system-background screen (empty
UILaunchScreendict). This declares a minimal static launch screen: the cmux chevron mark (34x48pt) centered on aLaunchBackgroundcolor that matches the first screen's plainsystemBackground(white in light, black in dark).The mark is rendered from the canonical brand chevron in
web/public/cmux-icon.svg(gradient#12c7f5->#2d8cff->#6c5cff). The first cut used the app-bundledCmuxLogoraster, whose gradient is noticeably more purple than the brand mark on cmux.com; that asset (still used by the sign-in header) remains off-brand and is a candidate for a separate alignment PR.HIG check: followed the Launching page (https://developer.apple.com/design/human-interface-guidelines/launching). The launch screen is static with no text, matches the device appearance mode, and matches the first screen's solid background. The HIG discourages standalone branding; the mark is small, and the sign-in first screen already shows the same chevron in its brand header.
Localization audit: no user-facing strings added (launch screens cannot carry localized text, which is why there is no text).
No pbxproj changes; the new colorset and imageset live inside the already-referenced
ios/cmux/Assets.xcassets.🤖 Generated with Claude Code