fix(ios): public import for MobileWorkspacePreview.ID in capabilities API - #10290
Conversation
… API supportsPanelArtifacts(in:) exposes MobileWorkspacePreview.ID publicly, but the file imported CmuxMobileShellModel with a plain import, which is internal under InternalImportsByDefault. The Release device archive rejects it (method cannot be declared public because its parameter uses an internal type); Debug simulator builds do not, which is why test-ios stayed green. Matches the 24 sibling files in this package that already use public import. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe change makes ChangesPublic API export
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized import change exposes the required model type to the public capabilities API without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (24 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MacSurfaceGalleryPreviewView (#if DEBUG) builds TerminalPickerMenuActions without the required selectSimulatorStream closure, so every Debug iOS build from main fails compiling CmuxMobileShellUI while Release archives skip the file and stay green. Missed in the PR 10072 partial merge, same family as manaflow-ai#10287/manaflow-ai#10290/manaflow-ai#10295. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Third compile break from 04ff18e, behind the two switches fixed in #10287:
MobileShellComposite+Capabilities.swift:147declarespublic func supportsPanelArtifacts(in: MobileWorkspacePreview.ID)while importingCmuxMobileShellModelwith a plain (internal-by-default) import. Only the Release device archive rejects it, so test-ios simulator lanes stayed green while the TestFlight archive died: https://github.com/manaflow-ai/cmux/actions/runs/32072777777.One line:
public import CmuxMobileShellModel, matching the 24 sibling files in the package. Verifying with a fleet Release beta archive before merge.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Make the capabilities API buildable in Release by changing the import of
CmuxMobileShellModelto a public import. Previously,supportsPanelArtifacts(in: MobileWorkspacePreview.ID)was public while the import made the parameter type internal, causing Release device archives to fail; this aligns the import with the API without changing runtime behavior.public import CmuxMobileShellModelin MobileShellComposite+Capabilities.swift, matching sibling files.Written for commit 789585e. Summary will update on new commits.
Summary by CodeRabbit