Repository navigation
docs(tui): align frontend protocol references - #10246
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 17, 2026
lawrencecchen
force-pushed
the
fix-tui-frontend-protocol-docs
branch
from
September 1, 2026 19:49
a4a0767 to
d3717a2
Compare
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
lawrencecchen
force-pushed
the
fix-tui-frontend-protocol-docs
branch
from
September 1, 2026 19:59
d3717a2 to
e13626d
Compare
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 1, 2026
6044a8b docs(tui): align frontend protocol references (manaflow-ai#10246) 56457e4 perf(cmux-tui): avoid cloning projection specs per frame (manaflow-ai#11487) 9503718 ci: guard focused filters that match only ignored tests
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
a0ec52cfd2adds the failing contract test (red)a4a0767325updates docs and workflow wiring (green)python3 cmux-tui/scripts/test_frontend_docs.py -vpython3 -m py_compile cmux-tui/scripts/test_frontend_docs.pyactionlintNo build, package publication, workflow dispatch, or merge was performed. This PR is independent of #10241 and #10242.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Aligns frontend README protocol references to v12 and adds a contract test so docs can't drift from the supported WebSocket protocol. READMEs previously could claim an outdated protocol version with nothing enforcing it; now the spec workflow fails when they mismatch.
frontends/README.md,frontends/README.ja.md, andfrontends/web/README.ja.mdto reference protocol v12.cmux-tui/scripts/test_frontend_docs.pyto assert that the web client'sSUPPORTED_PROTOCOL, the protocol guide heading, and README claims all match.cmux-tui-spec.ymlso version drift fails the workflow.frontends/web/src/lib/protocol.tsanddocs/protocol.mdfirst, then fix README references to the new version.Written for commit e13626d. Summary will update on new commits.