Skip to content

Await published browser tab state in TUI smoke test - #10026

Merged
lawrencecchen merged 2 commits into
feat-tui-iroh-iosfrom
feat-tui-smoke-active-screen-readiness
Aug 12, 2026
Merged

lawrencecchen merged 2 commits into
feat-tui-iroh-iosfrom
feat-tui-smoke-active-screen-readiness

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • replace fixed prefix-B and close delays with one final-deadline readiness probe
  • observe the active workspace, active screen, and requested browser-tab count
  • report the final workspace tree if publication never completes

Evidence

  • red: PR9952 hosted run 31551446482 sampled list-workspaces before an active screen was published
  • static: diff check passed
  • local xhigh review: clean, 0.96
  • local compile/tests: not run by instruction

Ledger effect: 0


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Make the TUI smoke test wait for the published active screen and browser tab state, removing flakiness when opening and closing the browser tab.

  • Bug Fixes
    • Added wait_for_active_screen(predicate, description, seconds) to poll the workspace tree until the active screen matches the expected tab count/kind.
    • Replaced fixed delays in the browser open/close paths with the readiness probe, and switched to the CloseTab owner action (prefix-x) to avoid closing the pane.
    • On timeout, fail with the last workspace tree to aid debugging.

Written for commit c144d29. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fc723886-e26d-408c-82f9-413cbc36b5d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@lawrencecchen
lawrencecchen merged commit 4f327a1 into feat-tui-iroh-ios Aug 12, 2026
5 checks passed
@lawrencecchen
lawrencecchen deleted the feat-tui-smoke-active-screen-readiness branch August 12, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant