Skip to content

Test remote latency under memory instrumentation - #10025

Merged
lawrencecchen merged 1 commit into
feat-tui-iroh-iosfrom
feat-valgrind-latency-policy
Aug 12, 2026
Merged

lawrencecchen merged 1 commit into
feat-tui-iroh-iosfrom
feat-valgrind-latency-policy

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • inject a memory-instrumentation workload profile into the bidirectional interactive latency test
  • preserve transport owners, epoch fences, payload digests, and the unchanged final watchdog
  • keep the full 64 MiB and latency bounds as the default profile

Evidence

  • red: PR9952 hosted run 31551446482 reached the final 90-second watchdog under Valgrind after making progress, with zero Valgrind errors
  • static: direct rustfmt and diff checks passed
  • local xhigh review: clean, 0.94
  • local compile/tests: not run by instruction

Ledger effect: 0


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Add a memory-instrumented workload profile to the bidirectional interactive latency e2e test, selectable via CMUX_TEST_MEMORY_INSTRUMENTATION, so we can run under Valgrind without flakiness while keeping the default 64 MiB profile unchanged.

  • New Features
    • Introduced a Workload profile to parameterize bulk size, echo count, and latency checks.
    • Default workload: 64 MiB, 256 echoes, enforces p95/p99 bounds.
    • Memory-instrumented workload: 4 MiB, 32 echoes, skips p95/p99 checks; keeps both directions, receiver fences, payload digests, and the 90s watchdog.
    • Enable by setting CMUX_TEST_MEMORY_INSTRUMENTATION=1; other values panic.

Written for commit b65e8c9. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8f3bf276-37ad-4ff7-95c9-945909d88b8a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen
lawrencecchen merged commit cf6619b into feat-tui-iroh-ios Aug 12, 2026
6 checks passed
@lawrencecchen
lawrencecchen deleted the feat-valgrind-latency-policy branch August 12, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant