Keep provider selection pending until connectable

[lawrencecchen]

Summary

• keep accepted provider selection pending until the owner reports the selected machine connectable
• use one readiness helper for refresh and reconnect snapshot installation
• prove deferred readiness with protocol responses and no timing

Verification

• red evidence: https://github.com/manaflow-ai/cmux/actions/runs/31522445966/job/93882610535
• rustfmt check: pass
• git diff --check: pass
• isolated gpt-5.6-sol xhigh review: clean, 0.96
• hosted exact-head behavior proof: pending

No local compile or tests were run.

---

Summary by cubic

Hold provider selection until the chosen machine is connectable, applying it only when snapshots confirm readiness. Pending selection persists across refresh, observation, and a one-shot reconnect; explicit switches now cancel it on commit.

• Bug Fixes
  • Added apply_accepted_selection_if_ready and used it in refresh, reconnect snapshot installation, and observation.
  • Cleared deferred selection only when a provider switch commits; kept it for mandatory/aborted replacements and across a single reconnect without re-scheduling.

^{Written for commit 9a492b8. Summary will update on new commits.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9ad766d0-7164-456d-984c-b6a1533abfcf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78f04ce948

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.