Skip to content

Merge main's pin into the terminal-size presence branch (follow-up to #259) - #266

Merged
lawrencecchen merged 1 commit into
mainfrom
feat/terminal-size-presence
Sep 30, 2026
Merged

lawrencecchen merged 1 commit into
mainfrom
feat/terminal-size-presence

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Sep 30, 2026 •

Copy link
Copy Markdown

cmux #15203 now pins bonsplit 83857fa, a merge of bonsplit 287e473 (the pin on cmux main) into feat/terminal-size-presence after #259 merged. Merging this with a merge commit makes 83857fa an ancestor of bonsplit main, as the submodule pointer rule requires.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Merges main's cmux pin into the terminal-size-presence branch, keeping the pinned bonsplit commit an ancestor of bonsplit main as the submodule pointer rule requires. Also carries over the pinned main changes.

  • Split buttons can now be hover-only outside minimal mode via splitButtonsOnHover.
  • Tab text and shortcut-hint pills pick dark or light chrome by WCAG contrast instead of a simple luminance cutoff, so saturated mid-tone backgrounds get readable text.

Written for commit 83857fa. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • New Features

    • Added an option to show split buttons on tab-bar hover in standard mode. Hover-only buttons overlay the tab bar without reserving space; always-visible buttons reserve a lane.
    • Shortcut hints now adapt their colors to the tab bar’s light or dark appearance.
  • Bug Fixes

    • Improved active text color choices for custom tab-bar backgrounds to support more readable contrast across a wider range of colors.
  • Documentation

    • Clarified how hover-only split buttons appear and compare with minimal mode.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5284422b-475b-40d9-aa63-6079ecd1a1b9

📥 Commits

Reviewing files that changed from the base of the PR and between ee1500c and 83857fa.

📒 Files selected for processing (6)
  • Sources/Bonsplit/Internal/Styling/TabBarColors.swift
  • Sources/Bonsplit/Internal/Views/TabBarView.swift
  • Sources/Bonsplit/Internal/Views/TabItemView.swift
  • Sources/Bonsplit/Public/BonsplitConfiguration.swift
  • Tests/BonsplitTests/BonsplitTests.swift
  • Tests/BonsplitTests/TabBarTextSchemeTests.swift
 ____________________________________________________________
< When you say, “I meant to do that,” I totally believe you. >
 ------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen
lawrencecchen merged commit 807396a into main Sep 30, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant