Repository navigation
Test-only proof: wide-title tab drag regression - #216
Draft
austinywang wants to merge 1 commit into
Draft
austinywang wants to merge 1 commit into
austinywang wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected-red CI proof for the first commit of #215.
This draft intentionally contains only the behavioral regression tests from
0dc3b6d; the strip-wide destination and resolver are absent, so CI must fail. The production fix remains in #215.Related: manaflow-ai/cmux#10033
Summary by cubic
Adds failing regression tests that prove the wide-title tab drag bug and the need for a strip-wide tab-bar drop destination that resolves insertion slots over tabs and trailing chrome. Intentionally test-only; CI will fail until the implementation lands. Related to issue #10033.
TabBarDropHandlerTests,TabDropIndexResolverTests, andTabWideTitleDragTeststo cover insertion index resolution (including wide tabs), same/cross-pane moves, live-drag vs pasteboard behavior, and destination hit-testing.TabDropDelegateSamePaneFallbackTestsand updatedBonsplitTeststo assert a strip-wide drop destination spans rendered tabs and trailing chrome.Written for commit 0dc3b6d. Summary will update on new commits.