Skip to content

fix: Empty column normalization with EMPTYVAL #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 12, 2023
Merged

fix: Empty column normalization with EMPTYVAL #804

merged 16 commits into from
Sep 12, 2023

Conversation

@jjerphan
Copy link
Collaborator

@jjerphan jjerphan commented Aug 29, 2023 •
edited
Loading

Reference Issues/PRs

Follow-up of #540.

What does this implement/fix? How does it work (high level)? Highlight notable design decisions.

See this thread #540 (comment).

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings and documentation?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@jjerphan
wip: Using NoneType directly
b125207 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan force-pushed the pandas-2.0/none-type branch from 2c91bd0 to b125207 Compare August 29, 2023 16:35
@jjerphan jjerphan mentioned this pull request Aug 30, 2023
Closed
@jjerphan
Copy link
Collaborator Author

jjerphan commented Aug 30, 2023 •
edited
Loading

The only test that fails is test_fallback_to_pickle which has to be removed since #646 has been merged.

#805 removes test_fallback_to_pickle.

@jjerphan jjerphan mentioned this pull request Aug 30, 2023
Merged
5 tasks
@jjerphan jjerphan marked this pull request as ready for review August 30, 2023 14:02
@jjerphan jjerphan mentioned this pull request Aug 30, 2023
Merged
@jjerphan jjerphan changed the title fix: Empty column normalization with NoneType fix: Empty column normalization with EMPTYVAL Sep 4, 2023
@jjerphan
Reintroduce the type for coercion again
5054b69 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Add an entry for EMPTYVAL in get_dtype_specifier
febb162 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Use SizeBits::S64 for all empty tensor
7e4578b 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
test: Do not check dtype for now
25565a7 
Columns' types coercion (on the Python layer) has not been adapted yet.

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Fix column checks for static schemas
5f4473a 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Allow compatible type in FieldCollection checks
af4a120 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
test: Relax tests for now
61e20a7 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan mentioned this pull request Sep 11, 2023
Merged
5 tasks
jjerphan
jjerphan commented Sep 12, 2023
View reviewed changes
@jjerphan jjerphan added the enhancement New feature or request label Sep 12, 2023
@jjerphan jjerphan merged commit ea154f2 into master Sep 12, 2023
@jjerphan jjerphan deleted the pandas-2.0/none-type branch September 12, 2023 12:03
@jjerphan jjerphan mentioned this pull request Sep 20, 2023
Closed
@phoebusm phoebusm mentioned this pull request Oct 10, 2023
Closed
grusev pushed a commit that referenced this pull request Nov 25, 2024
@jjerphan
fix: Empty column normalization with EMPTYVAL (#804)
82ef13e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@willdealtry willdealtry willdealtry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jjerphan @willdealtry