Enhancement: Implement Library.get_key_path for NFS and Azure storages #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-morozov
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
poodlewars
reviewed
Feb 11, 2025
| res.emplace_back(found_key); | ||
| }, ""); | ||
|
|
||
| for(auto vk=res.begin(); vk!=res.end(); ++vk) { |
|
Are some changes to create Python bindings missing? I don't understand how you're planning to use this. I also don't follow how these functions will help with quotas? |
The usage is like this: For quotas we will obtain the path to the data |
Can you include a test that does that please? I think you're missing Python bindings for your new library tool API. |
poodlewars
approved these changes
Feb 12, 2025
maxim-morozov
force-pushed
the
expose_key_path
branch
from
7a4a12e to
5904fad
Compare
vasil-pashov
approved these changes
Feb 13, 2025
| std::vector<VariantKey> res; | ||
|
|
||
| store.iterate_type(KeyType::TABLE_DATA, [&](VariantKey &&found_key) { | ||
| res.emplace_back(found_key); |
There was a problem hiding this comment.
Suggested change
| res.emplace_back(found_key); | |
| res.emplace_back(std::move(found_key)); |
| res.emplace_back(found_key); | ||
| }, ""); | ||
|
|
||
| for(auto vk: res) { |
There was a problem hiding this comment.
Suggested change
| for(auto vk: res) { | |
| for(const auto& vk: res) { |
|
|
||
| auto store = get_storage(); | ||
| store->iterate_type(KeyType::TABLE_DATA, [&](VariantKey &&found_key) { | ||
| res.emplace_back(found_key); |
There was a problem hiding this comment.
Suggested change
| res.emplace_back(found_key); | |
| res.emplace_back(std::move(found_key)); |
| res.emplace_back(found_key); | ||
| }, ""); | ||
|
|
||
| for(auto vk : res) { |
There was a problem hiding this comment.
Suggested change
| for(auto vk : res) { | |
| for(const auto& vk : res) { |
jamesmunro
pushed a commit
that referenced
this pull request
Feb 25, 2025
#### Reference Issues/PRs Expose `Library.get_key_path` for NFS and Azure storages. #### What does this implement or fix? get_key_path will be used to determine where each key is located. This can help to set hard quotas for the platforms that support path based quotas, like VAST. #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [x] Are API changes highlighted in the PR description? - [x] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing --> --------- Co-authored-by: Maxim Morozov <[email protected]>
maxim-morozov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Expose
Library.get_key_pathfor NFS and Azure storages.What does this implement or fix?
get_key_path will be used to determine where each key is located. This can help to set hard quotas for the platforms that support path based quotas, like VAST.
Any other comments?
Checklist
Checklist for code changes...