Don't warn about missing keys when reading symbol ref as it is common to try to read a non-existent symbol #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to try to read a non-existent symbol 8350109779
alexowens90
approved these changes
Jan 29, 2025
phoebusm
approved these changes
Jan 29, 2025
jamesmunro
pushed a commit
that referenced
this pull request
Feb 25, 2025
… to try to read a non-existent symbol (#2153) Tested manually running this script: ``` from arcticdb import Arctic import pandas as pd import arcticdb_ext as ae print(ae.__file__) ac = Arctic("s3://172.17.0.2:9000:aseaton?access=3SePAqKdc1O7JgeDIJob&secret=...") lib = ac.get_library("tst_logging", create_if_missing=True) df = pd.DataFrame({"a": [1, 2, 3]}) lib.write("tst", df) lib.has_symbol("aaa") ``` Before the change this logged, ``` (310) ➜ python git:(aseaton/8350109779/noisy-logging) ✗ python ./tst.py /home/alex/venvs/310/lib/python3.10/site-packages/arcticdb_ext.cpython-310-x86_64-linux-gnu.so 20250129 10:56:31.466366 175505 W arcticdb | Failed to find segment for key 'r:aaa' : No response body. 20250129 10:56:31.466924 175505 W arcticdb | Failed to find segment for key 'V:aaa' : No response body. ``` after the change this logged, ``` (310) ➜ python git:(aseaton/8350109779/noisy-logging) ✗ python ./tst.py /code/arcticdb.git/man_bug/python/arcticdb_ext.cpython-310-x86_64-linux-gnu.so ``` The suppression got dropped in 32341ae . #### Reference Issues/PRs 8350109779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested manually running this script:
Before the change this logged,
after the change this logged,
The suppression got dropped in 32341ae .
Reference Issues/PRs
8350109779