Backport list versions and delete_snapshot race 8104588520 #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2092) See arcticc PR #1170 for more context and discussion. The keys in the `KeysNotFoundException` were not having `unencode_object_id` applied to them, so in the snapshot iteration we were incorrectly thinking they were different to the snapshot key being iterated over (which has had the unencoding applied).
I need to test against the NFS style backend in the `arcticdb-enterprise` repo so I need these test fixture improvements. I thought it would be worthwhile adding an NFS backend test while I'm here, as a way to make sure that the fixtures are maintained properly. Motivation: man-group/arcticdb-enterprise#139
poodlewars
force-pushed
the
aseaton/bug/4.4.x/list-versions-snapshots-race
branch
2 times, most recently
from
f512630 to
e90e9ea
Compare
willdealtry
approved these changes
Jan 6, 2025
poodlewars
force-pushed
the
aseaton/bug/4.4.x/list-versions-snapshots-race
branch
from
e90e9ea to
0091de2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports of:
#1719 (testing infra for NFS backend)
#2092 (fix race between list versions and deleting snapshots)
Dropped the C++ unit test added in PR 2092 as it relies on some support for testing with mocked out NFS backends that I don't want to backport. The Python test is end to end and should suffice.
Skip the Windows CI as it has rotted on
4.4.x. We don't have a customer who needs LTS 4.4.x releases on Windows.