Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Windows CI to VS 17.9.7 toolset as runner image update has build failures #1611

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Pin Windows CI to VS 17.9.7 toolset as runner image update has build failures #1611

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
449d951
Update MSVC toolset as per runner image update
muhammadhamzasajjad Jun 10, 2024
0d96ed1
Install msvc 17.9
muhammadhamzasajjad Jun 10, 2024
b5dab50
Remove toolset pin
muhammadhamzasajjad Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/build_steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,16 @@ jobs:
disk-root: "D:" # This is also the checkout directory. Total size 12GB.
continue-on-error: true

- name: Install VS2022 BuildTools 17.9.7
if: matrix.os == 'windows'
run: choco install -y visualstudio2022buildtools --version=117.9.7.0 --params "--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 --installChannelUri https://aka.ms/vs/17/release/180911598_-255012421/channel"

- name: Enable Windows compiler commands
if: matrix.os == 'windows'
uses: ilammy/[email protected]
with:
vasil-pashov marked this conversation as resolved.
Show resolved Hide resolved
# The version of the toolset is specified due to faulty version discovery.
toolset: 14.39
toolset: 14.40

- name: Extra envs
# This has to come after msvc-dev-cmd to overwrite the bad VCPKG_ROOT it sets
Expand Down
Loading