maint: Replace use of folly getCurrentThreadId with STL #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Thomas <[email protected]>
ianthomas23
force-pushed
the
remove_folly_thread_id
branch
from
9ef489f to
551b256
Compare
ianthomas23
changed the title
alexowens90
reviewed
Mar 12, 2024
| @@ -67,7 +66,8 @@ struct StorageLockTimeout : public std::runtime_error { | |||
| }; | |||
|
|
|||
| inline uint64_t get_thread_id() { | |||
| return folly::getCurrentThreadID(); | |||
| auto thread_id = std::this_thread::get_id(); | |||
| return std::hash<std::thread::id>()(thread_id); | |||
There was a problem hiding this comment.
This function is only used in logging, so can return the std::thread::id directly provided fmt can handle it
|
Closing this, I will replace it with another PR from a branch in this repo rather than my fork of it. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
This is work to assist @jjerphan in removing use of folly in the ArcticDB code base.
The change here is to remove use of
folly::getCurrentThreadID()inget_thread_id(), replacing it with use ofstd::this_thread::get_id().Any other comments?
The folly implementation is much more complicated as there are different implementation for the 3 major OSes:
https://github.com/facebook/folly/blob/69a1b93df285457cd0799a6898e2e5390a09cd73/folly/system/ThreadId.cpp#L29-L37
The different implementations are not required as the STL C++11 solution should work on all OSes. I have kept the return type as
uint64_tand hence am using the STLthread::hashspecialisation to convert the implementation-specificthread_idto integer. It is possible for two thread IDs to have the same hash, but this has negligible mathematical probability, and also it doesn't matter of there are hash collisions as the only use ofget_thread_idis in log messages.Checklist
Checklist for code changes...