Do not read/write the APPEND_REF key when calling write/append with incomplete=True on the V1 API
#1937
Assignees
Labels
bug
Something isn't working
Comments
alexowens90
changed the title
APPEND_REF key when calling append with incomplete=True on the V1 APIAPPEND_REF key when calling write/append with incomplete=True on the V1 API
grusev
pushed a commit
that referenced
this issue
Nov 25, 2024
) #### Reference Issues/PRs Fixes #1937 #### What does this implement or fix? See ticket for details. Being able to create the append ref linked-list structure is useful for testing, so moved this to the `LibraryTool`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Calling
write/appendwithincomplete=Trueeventually callsversion_store.append_incomplete. This method reads theAPPEND_REFkey, modifies thenext_keyfield of theTimeSeriesDescriptor, and then writes it back to storage again.This is pointless, as
compact_incompletesas accessible to users ignores the linked-list structure, and collectsAPPEND_DATAkeys via iteration. In addition, in a truly parallelwrite/append, the linked list would not be in the correct order anyway.Calling write with
parallel=Truedoes the correct thing. Namely, writingAPPEND_DATAkeys without touching the linked-list structure. Bothwriteandappendwithincomplete=Trueshould be modified to do the same thing.The functionality to write linked-list structures of
APPEND_DATAkeys is useful for testing though, so this should be moved to theLibraryTool.The text was updated successfully, but these errors were encountered: